Fix translation loading state and prevent infinite spinner#1516
Open
sai-kamal0905 wants to merge 2 commits intointernetarchive:masterfrom
Open
Fix translation loading state and prevent infinite spinner#1516sai-kamal0905 wants to merge 2 commits intointernetarchive:masterfrom
sai-kamal0905 wants to merge 2 commits intointernetarchive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Raise error if translating from/to same language #1488 and fixes an issue where the translation loading state could remain active even when no translation was performed.
Changes:
This prevents the UI from getting stuck in a loading state and improves async state management.