feat: add ability to execute custom scripts and commands#472
Merged
ivanhernandez13 merged 2 commits intoios-control:masterfrom Sep 1, 2020
Merged
Conversation
|
Thanks, this does solve my concerns from #338. Does this mean any scripts used with this option need to be pre-processed to add the escaping that the Xcode project uses |
Author
|
No. The escaping is needed for stuff that is embedded in c source but not custom scripts. The xcode stuff is used to transform the py file to the c string like: As we are not including the custom scripts into c code, no preprocessing is required. |
|
Cool, this will make things easier for many people |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmit of the #338 with a different approach.
This does not require the custom script to re implement the whole fruitstrap python script, but, if required, override some functionality by specifying own implementation of the function.