Removes legacy support for a custom-built version of pinocchio#4713
Conversation
Greptile SummaryThis PR removes legacy support for a custom-built pinocchio version that was previously required due to CXX ABI compatibility issues with Isaac Sim. Now that Isaac Sim uses standard pinocchio with CXX ABI=0, the workarounds are no longer needed. Key changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User Scripts] -->|Before: --enable_pinocchio flag| B[Manual import pinocchio]
B -->|Force pip version| C[Import pinocchio_envs]
C --> D[Load GR1T2/G1 Envs]
E[User Scripts] -->|After: No flag needed| F[Standard imports]
F -->|Use Isaac Sim's pinocchio| G[Import from envs/]
G --> H[Load GR1T2/G1 Envs]
I[isaaclab_tasks/__init__.py] -->|Before| J[Blacklist: pick_place]
I -->|After| K[No blacklist for pick_place]
style B fill:#ffcccc
style C fill:#ffcccc
style J fill:#ffcccc
style F fill:#ccffcc
style G fill:#ccffcc
style K fill:#ccffcc
Last reviewed commit: a895333 |
Additional Comments (3)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
…-sim#4713) ## Description This PR removes legacy support for a custom-built version of `pinocchio` that was previously required due to CXX ABI compatibility constraints with Kit in Isaac Sim. Now that Isaac Sim is transitioning to use a standard `pinocchio` build with `CXX ABI=0`, we can streamline the integration with IsaacLab and Pink. ### Summary of Changes - Removed all manual `import pinocchio` statements from user-facing scripts that previously ensured the pip-installed version was used. - Removed (or marked for removal) `enable_pinocchio` flags across the repo. - Removed the `pick_place` task from the task blacklist in `__init__.py`. - [Reference](https://github.com/isaac-sim/IsaacLab-Internal/blob/devel/source/isaaclab_tasks/isaaclab_tasks/__init__.py#L29) - Removed the `pinocchio_envs` subdirectory as it is no longer needed. > **Note:** Pinocchio and Pink are still not available on Windows. These changes assume usage on supported platforms (e.g., Linux). ## Motivation and Context This change helps to unify the use of the `pinocchio` library across Isaac Sim and IsaacLab, reducing maintenance overhead. ## Type of Change - [x] Cleanup / Tech Debt - [x] Bug fix (non-breaking) ## Screenshots N/A - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation (if applicable) - [x] My changes generate no new warnings - [x] I have updated the changelog and the version in `config/extension.toml` - [x] I have added myself to `CONTRIBUTORS.md` (or already listed)
Description
This PR removes legacy support for a custom-built version of
pinocchiothat was previously required due to CXX ABI compatibility constraints with Kit in Isaac Sim. Now that Isaac Sim is transitioning to use a standardpinocchiobuild withCXX ABI=0, we can streamline the integration with IsaacLab and Pink.Summary of Changes
import pinocchiostatements from user-facing scripts that previously ensured the pip-installed version was used.enable_pinocchioflags across the repo.pick_placetask from the task blacklist in__init__.py.pinocchio_envssubdirectory as it is no longer needed.Motivation and Context
This change helps to unify the use of the
pinocchiolibrary across Isaac Sim and IsaacLab, reducing maintenance overhead.Type of Change
Screenshots
N/A
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlCONTRIBUTORS.md(or already listed)