bugfix: init ssm_cache by config ssm_cache_type and fix dimension order of g & beta for qwen3.5.#1259
Merged
yingxudeng merged 8 commits intojd-opensource:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the LLMEngine and WorkerImpl components, providing the core infrastructure for distributed inference, KV cache management, and model lifecycle operations. It adds support for advanced architectures like DeepSeek v3 and Qwen3, along with optimizations such as XTensor memory management and rolling weight loading. The review feedback suggests enhancing type safety by using enums instead of string literals for model arguments. Additionally, the implementation should be refined to adhere to the project's style guide, particularly concerning fixed-width integer usage, constant naming conventions, and the appropriate use of the auto keyword.
d76d019 to
e42f91b
Compare
e42f91b to
25ef04b
Compare
XuZhang99
reviewed
Apr 11, 2026
yq33victor
reviewed
Apr 11, 2026
Contributor
Author
|
/gemini-review |
Contributor
Author
|
/gemini-review |
JimHsiung
previously approved these changes
Apr 14, 2026
XuZhang99
previously approved these changes
Apr 14, 2026
9423f68
yingxudeng
approved these changes
Apr 15, 2026
zhang-minchao
approved these changes
Apr 15, 2026
Collaborator
DongheJin
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR makes the following changes to the xLLM inference engine: