bugfix: unify device_index logging conversion with helper overloads#1263
Open
kuma-loong wants to merge 2 commits intojd-opensource:mainfrom
Open
bugfix: unify device_index logging conversion with helper overloads#1263kuma-loong wants to merge 2 commits intojd-opensource:mainfrom
kuma-loong wants to merge 2 commits intojd-opensource:mainfrom
Conversation
kuma-loong
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a utility function to_int32_device_index in core/platform/device.h to standardize the conversion of device indices to int32_t for logging and NUMA mapping. The changes update the distributed runtime, CUDA kernels, and graph executors to utilize this helper. Feedback was provided to ensure that new include statements follow the repository's style guide by using project-root-relative paths.
XuZhang99
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
device_indexappearing asnullin logs when graph_mode is enabled.