fix: Variable Replacement does not work properly in team roadmaps, Issue Number: #9557#9569
Open
akurtle wants to merge 1 commit intokamranahmedse:masterfrom
Open
fix: Variable Replacement does not work properly in team roadmaps, Issue Number: #9557#9569akurtle wants to merge 1 commit intokamranahmedse:masterfrom
akurtle wants to merge 1 commit intokamranahmedse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bug:
The variable '@currentYear@' was not replaced by the new Date().getFullYear().toString() as expected by the replaceVariables function in src/lib/markdown.ts.
It is displayed as raw text '@currentYear@' in the page view. You can check this for yourself using the link above or by looking at the picture below.
The solution:
The markdown in markdownToHtml was not using the replaceVariables function so it was not being replaced
also changed the p tag to use the markdownToHtml function
works as expected now
