Use phrity/websocket instead of textalk#67
Open
RobertBoes wants to merge 1 commit intolaravel-notification-channels:masterfrom
Open
Use phrity/websocket instead of textalk#67RobertBoes wants to merge 1 commit intolaravel-notification-channels:masterfrom
RobertBoes wants to merge 1 commit intolaravel-notification-channels:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like textalk/websocket is no longer maintained; Textalk/websocket-php#191 (comment) / Textalk/websocket-php#183
I made a PR to their repo, since upgrading to
1.6.3isn't possible because it requirespsr/http-message@^1.0, many Laravel apps have 2.x installed.Installing
phrity/websocketversion 2.x doesn't work yet, because it has breaking changes, I can work on that too, but I think requiring ^1.5 would be a good first step as it's a drop-in replacement