Merged
Conversation
Fixed the maven shade command so it produces a valid shaded package name. It was producing shaded.cloud-nio.* which is not a valid java package and causes compilation errors when trying to import those packages. This is problematic since the shaded packages are exposed in the API, so methods that exposed them were unusable by client code. Shading now produces shading.cloud_nio.* which is valid
lbergelson
pushed a commit
that referenced
this pull request
Jan 9, 2018
Retry on 403 "Forbidden" errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the maven shade command so it produces a valid shaded package name. It was producing shaded.cloud-nio.* which is not a valid java package and causes compilation errors when trying to import those packages. This is problematic since the shaded packages are exposed in the API, so methods that exposed them were unusable by client code.
Shading now produces shading.cloud_nio.* which is valid