Introduce default_config top-level function#242
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Feb 7, 2024
Merged
Conversation
.. this allows us the retrieve a `Config` prepopulated with default values in bindings (where `Default::default()` isn't available), even if it includes complex structures for which we can't set default values in the UDL file.
G8XSU
reviewed
Feb 5, 2024
| /// | ||
| /// This is mostly meant for use in bindings, in Rust this is synonymous with | ||
| /// [`Config::default()`]. | ||
| pub fn default_config() -> Config { |
Contributor
There was a problem hiding this comment.
should this be "uniffi" flagged?
Collaborator
Author
There was a problem hiding this comment.
Yeah, good question. I debated that in my head to for a bit, I currently left it exposed in Rust too as the Rust docs are the only discoverable docs we have currently. It might be confusing if we'd only expose this in bindings.
I have no super strong opinion on this though.
G8XSU
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. this allows us the retrieve a
Configprepopulated with default values in bindings (whereDefault::default()isn't available), even if it includes complex structures for which we can't set default values in the UDL file.