Provide a valid (but still static) trace ID for the invocation#10
Merged
dominikschubert merged 1 commit intolocalstackfrom Jan 25, 2023
Merged
Provide a valid (but still static) trace ID for the invocation#10dominikschubert merged 1 commit intolocalstackfrom
dominikschubert merged 1 commit intolocalstackfrom
Conversation
dfangl
approved these changes
Jan 24, 2023
Comment on lines
+101
to
+112
| //TraceID: GetEnvOrDie("_X_AMZN_TRACE_ID"), // r.Header.Get("X-Amzn-Trace-Id"), | ||
| // TODO: set correct segment ID from request | ||
| //LambdaSegmentID: "LambdaSegmentID", // r.Header.Get("X-Amzn-Segment-Id"), | ||
| //CognitoIdentityID: "", | ||
| //CognitoIdentityPoolID: "", | ||
| //DeadlineNs: "", | ||
| //ClientContext: "", | ||
| //ContentType: "", | ||
| //ReservationToken: "", | ||
| //VersionID: "", | ||
| //InvokeReceivedTime: 0, | ||
| //ResyncState: interop.Resync{}, |
Member
Author
There was a problem hiding this comment.
Just keeping track of what's missing. It's just the full Invoke construct with all defaults. Can see them as a todo I guess 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the .NET AWS SDK was broken with the previous value since its format doesn't conform to the official X-Ray trace ID.
We'll have to properly set these within an upcoming project where we'll add x-ray integration. /cc @joe4dev