Skip to content

Require httpx 0.13#54

Closed
hugovk wants to merge 1 commit intolundberg:masterfrom
hugovk:httpx-0.13
Closed

Require httpx 0.13#54
hugovk wants to merge 1 commit intolundberg:masterfrom
hugovk:httpx-0.13

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented May 23, 2020

This PR is really an issue in the form of a PR to demonstrate RESPX does not yet support the new httpx 0.13 release.

The internal concurrency _backends was dropped from httpx in encode/httpx#901.

Example tests failure:

httpx 0.13 is intended to be the last before the 1.0 release:

@florimondmanca
Copy link
Copy Markdown
Contributor

It might be quite interesting to see if RESPX can now leverage the newly public Transport API to provide a complete « here’s how to send a mocked request » backend instead of patching the networking calls...

But that would probably require users to pass a transport=... parameter to their client - which is typically not possible assuming the requests being mocked are made in a different part of the code.

But then maybe the proposed mount API https://github.com/encode/httpx/issues/977 could be useful to « patch » the default transports for http:// and https://... Not sure at this point.

In any case, the concurrency backends aren’t gone. They were moved to the httpcore package since the networking layer is now handled there. So as a hot fix it should be possible to import them from there instead of HTTPX.

@lundberg
Copy link
Copy Markdown
Owner

Yes @florimondmanca this will be interesting and fun to solve 😅, multiple paths and choices to tackle.

@hugovk hugovk mentioned this pull request May 25, 2020
@lundberg
Copy link
Copy Markdown
Owner

Closing this in favour of #57 .

@florimondmanca RESPX mocking is now handled as a transport 🎉

@lundberg lundberg closed this May 29, 2020
@lundberg
Copy link
Copy Markdown
Owner

@hugovk please try out #57

@hugovk hugovk deleted the httpx-0.13 branch May 29, 2020 11:43
@hugovk hugovk mentioned this pull request Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants