[@Mantine/core] refactor and fix MenuItem component behavior#7948
Closed
Han5991 wants to merge 3 commits intomantinedev:masterfrom
Closed
[@Mantine/core] refactor and fix MenuItem component behavior#7948Han5991 wants to merge 3 commits intomantinedev:masterfrom
Han5991 wants to merge 3 commits intomantinedev:masterfrom
Conversation
Prevent default mousedown behavior only for non-draggable and non-interactive elements within MenuItem. Added additional checks and comprehensive tests to handle various edge cases, including nested elements and form controls.
Streamlined tests by eliminating duplicate and overly specific cases, focusing on core interactive element behavior. This improves maintainability and reduces unnecessary test complexity.
Han5991
changed the title
Contributor
Author
|
@rtivital ? What does label mean? |
Member
|
It means that I'm not sure about PR and need to spend more time understanding the impact and purpose of changes. |
Member
|
Thanks for submitting a PR. I've reviewed the original issue and it turned out to be invalid, this fix is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #7939
Description
This pull request includes the following updates:
MenuItemtests to remove redundant cases, focusing on core interactive functionality. This enhances maintainability and simplifies future updates.mousedownbehavior handling in theMenuItemcomponent to ensure default behavior is prevented only for appropriate elements. Additional checks and tests were added to address edge cases, such as nested elements and form controls.