R^o type constraints in ln_concave#1010
Open
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
Open
R^o type constraints in ln_concave#1010affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
R^o type constraints in ln_concave#1010affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
Conversation
affeldt-aist
added
enhancement ✨
CohenCyril
reviewed
Aug 12, 2023
Comment on lines
+112
to
+147
| HB.instance Definition _ (R : realDomainType) := | ||
| ConvexSpace.copy R [the lmodType R of R^o]. | ||
| HB.instance Definition _ (R : realFieldType) := | ||
| ConvexSpace.copy R [the lmodType R of R^o]. | ||
| HB.instance Definition _ (R : realType) := | ||
| ConvexSpace.copy R [the lmodType R of R^o]. |
Member
There was a problem hiding this comment.
Isn't there a bunch of forgetful inheritance warnings here??
Member
Author
There was a problem hiding this comment.
Not with HB 1.3.0 Coq 8.15.1
Member
Author
There was a problem hiding this comment.
HB 1.4.0 Coq 8.16.1 seems fine also.
Member
There was a problem hiding this comment.
Yes, with mathcomp 1 HB does not detect it...
Member
Author
There was a problem hiding this comment.
HB 1.8.1 on Coq 8.20.1 detects the forgetful inheritances
affeldt-aist
added
help 🆘
Member
Author
|
I guess this is better to put this on hold. |
proux01
added
the
TODO: MC2 port
Member
Author
|
We can maybe close this PR because the problem that triggered it, i.e., the fact that there were Lemma concave_ln (t : {i01 R}) (a b : R^o) : 0 < a -> 0 < b ->
(ln a : R^o) <| t |> (ln b : R^o) <= ln (a <| t |> b).is no more. |
affeldt-aist
force-pushed
the
convex_20230811
branch
from
7a449cd to
5b488b5
Compare
affeldt-aist
removed
the
TODO: MC2 port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
address comment https://github.com/math-comp/analysis/pull/990/files/e686555022776816f6c70e98c00a1e6fd5923f95#diff-5edc277f753b88b71edd27b04c3075df73e37652e4c19c0f8dc6210fa57bf926
Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.