Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Set response values to zero if None for /_synapse/admin/v1/federation/destinations#16729

Merged
DMRobertson merged 3 commits intodevelopfrom
hs/destinations-list-fix-null
Dec 5, 2023
Merged

Set response values to zero if None for /_synapse/admin/v1/federation/destinations#16729
DMRobertson merged 3 commits intodevelopfrom
hs/destinations-list-fix-null

Conversation

@Half-Shot
Copy link
Copy Markdown
Collaborator

@Half-Shot Half-Shot commented Dec 5, 2023

The docs say these values should be integers (0 if no retries have been tried), but Synapse is currently returning null instead.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@Half-Shot Half-Shot requested a review from a team as a code owner December 5, 2023 10:14
Copy link
Copy Markdown
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DMRobertson DMRobertson merged commit ea78355 into develop Dec 5, 2023
@DMRobertson DMRobertson deleted the hs/destinations-list-fix-null branch December 5, 2023 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants