Removing cross-SDK tests from Python repo and cleaning up OTEL testing utility#361
Closed
rodrigobr-msft wants to merge 2 commits intomainfrom
Closed
Removing cross-SDK tests from Python repo and cleaning up OTEL testing utility#361rodrigobr-msft wants to merge 2 commits intomainfrom
rodrigobr-msft wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dev/testing/cross-sdk-tests suite (tests plus supporting sample agents/config) from the Python repo, aligning with the stated plan to refurbish and relocate these cross-SDK tests to a different/root repository.
Changes:
- Deleted cross-SDK pytest suite under
dev/testing/cross-sdk-tests/tests/(basic/core/telemetry scenarios). - Removed the bundled “quickstart” and “core-agent” sample agents (Python/.NET/JS) that supported those tests.
- Removed cross-SDK test harness configuration and templates (
pytest.ini, env templates, scripts, gitignore).
Reviewed changes
Copilot reviewed 44 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dev/testing/cross-sdk-tests/tests/telemetry/test_basic_telemetry.py | Removes placeholder telemetry test scaffolding. |
| dev/testing/cross-sdk-tests/tests/telemetry/init.py | Removes telemetry test package marker. |
| dev/testing/cross-sdk-tests/tests/core/test_webchat.py | Removes WebChat channel integration tests for the basic agent. |
| dev/testing/cross-sdk-tests/tests/core/test_msteams.py | Removes Microsoft Teams channel integration tests for the basic agent. |
| dev/testing/cross-sdk-tests/tests/core/test_directline.py | Removes DirectLine channel integration tests for the basic agent. |
| dev/testing/cross-sdk-tests/tests/core/test_basic_agent_base.py | Removes shared base class/scenario setup for core channel tests. |
| dev/testing/cross-sdk-tests/tests/core/init.py | Removes core test package marker. |
| dev/testing/cross-sdk-tests/tests/basic/test_quickstart.py | Removes quickstart scenario cross-SDK tests (Python/.NET/JS variants). |
| dev/testing/cross-sdk-tests/tests/basic/init.py | Removes basic test package marker. |
| dev/testing/cross-sdk-tests/tests/_common/utils.py | Removes helpers for scenario/agent path creation. |
| dev/testing/cross-sdk-tests/tests/_common/types.py | Removes SDKVersion enum used by cross-SDK scenarios. |
| dev/testing/cross-sdk-tests/tests/_common/source_scenario.py | Removes script-driven ExternalScenario runner used by cross-SDK tests. |
| dev/testing/cross-sdk-tests/tests/_common/constants.py | Removes constants for agent path/endpoint and entrypoints. |
| dev/testing/cross-sdk-tests/tests/_common/init.py | Removes exports for cross-SDK test helpers. |
| dev/testing/cross-sdk-tests/tests/init.py | Removes tests package marker. |
| dev/testing/cross-sdk-tests/pytest.ini | Removes pytest configuration dedicated to cross-SDK tests. |
| dev/testing/cross-sdk-tests/env.TEMPLATE | Removes shared env template for cross-SDK tests. |
| dev/testing/cross-sdk-tests/agents/quickstart/README.md | Removes documentation for the quickstart cross-SDK test agent. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/src/start_server.py | Removes aiohttp server bootstrap for the Python quickstart agent. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/src/main.py | Removes Python quickstart agent entrypoint wiring. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/src/agent.py | Removes Python quickstart agent implementation used by tests. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/src/init.py | Removes Python quickstart agent package marker. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/requirements.txt | Removes dependency list for Python quickstart agent. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/env.TEMPLATE | Removes Python quickstart agent env template. |
| dev/testing/cross-sdk-tests/agents/quickstart/python/_run_agent.ps1 | Removes PowerShell runner script for Python quickstart agent. |
| dev/testing/cross-sdk-tests/agents/quickstart/net/Quickstart.csproj | Removes .NET quickstart agent project file. |
| dev/testing/cross-sdk-tests/agents/quickstart/net/Program.cs | Removes .NET quickstart host startup code. |
| dev/testing/cross-sdk-tests/agents/quickstart/net/MyAgent.cs | Removes .NET quickstart agent logic implementation. |
| dev/testing/cross-sdk-tests/agents/quickstart/net/AspNetExtensions.cs | Removes ASP.NET auth helper extensions bundled for the sample. |
| dev/testing/cross-sdk-tests/agents/quickstart/net/_run_agent.ps1 | Removes PowerShell runner script for .NET quickstart agent. |
| dev/testing/cross-sdk-tests/agents/quickstart/js/tsconfig.json | Removes TS config for JS quickstart agent. |
| dev/testing/cross-sdk-tests/agents/quickstart/js/src/index.ts | Removes JS quickstart agent implementation used by tests. |
| dev/testing/cross-sdk-tests/agents/quickstart/js/package.json | Removes JS quickstart agent package manifest. |
| dev/testing/cross-sdk-tests/agents/quickstart/js/package-lock.json | Removes JS quickstart agent lockfile. |
| dev/testing/cross-sdk-tests/agents/quickstart/js/env.TEMPLATE | Removes JS quickstart agent env template. |
| dev/testing/cross-sdk-tests/agents/quickstart/js/_run_agent.ps1 | Removes PowerShell runner script for JS quickstart agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/README.md | Removes documentation for the “core-agent” test agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/plugins/weather_forecast.py | Removes WeatherForecast model used by core-agent tooling. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/plugins/weather_forecast_plugin.py | Removes Semantic Kernel weather plugin for core-agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/plugins/date_time_plugin.py | Removes Semantic Kernel date/time plugin for core-agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/plugins/adaptive_card_plugin.py | Removes Semantic Kernel adaptive-card generation plugin. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/plugins/init.py | Removes plugin package exports for core-agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/agents/weather_forecast_agent.py | Removes LLM-backed weather agent helper used by core-agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/agents/init.py | Removes weather agents package marker. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/weather/init.py | Removes weather package marker. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/config.py | Removes core-agent auth/LLM configuration object. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/app.py | Removes aiohttp app host for core-agent. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/agent.py | Removes core-agent routing/handler implementation. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/src/init.py | Removes core-agent Python src package marker. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/requirements.txt | Removes core-agent Python dependency list. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/README.md | Removes core-agent Python setup/run documentation. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/pre_requirements.txt | Removes core-agent “pre” dependency list. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/env.TEMPLATE | Removes core-agent Python env template. |
| dev/testing/cross-sdk-tests/agents/core-agent/python/init.py | Removes core-agent Python package marker. |
| dev/testing/cross-sdk-tests/.gitignore | Removes cross-SDK tests’ local ignore rules. |
| dev/testing/cross-sdk-tests/init.py | Removes cross-sdk-tests package marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rodrigobr-msft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are in the process of being refurbished and moved to the root repo