Replace only local type parameters with any when creating prototype property type of a class#57323
Closed
Andarist wants to merge 2 commits intomicrosoft:mainfrom
Closed
Conversation
…e` property type of a class
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Feb 7, 2024
| // It is an error to explicitly declare a static property member with the name 'prototype'. | ||
| const classType = getDeclaredTypeOfSymbol(getParentOfSymbol(prototype)!) as InterfaceType; | ||
| return classType.typeParameters ? createTypeReference(classType as GenericType, map(classType.typeParameters, _ => anyType)) : classType; | ||
| return classType.localTypeParameters ? createTypeReference(classType as GenericType, concatenate(classType.outerTypeParameters, map(classType.localTypeParameters, _ => anyType))) : classType; |
Contributor
Author
There was a problem hiding this comment.
I wonder if this doesn't create any type parameter leak or something like this but so far I couldn't recognize any unintended side-effect like this here.
typescript-bot
added
For Backlog Bug
…yify-only-local-type-params # Conflicts: # tests/baselines/reference/accessorsOverrideProperty9.types # tests/baselines/reference/amdDeclarationEmitNoExtraDeclare.types # tests/baselines/reference/anonClassDeclarationEmitIsAnon.types # tests/baselines/reference/baseConstraintOfDecorator.types # tests/baselines/reference/declarationEmitLocalClassDeclarationMixin.types # tests/baselines/reference/declarationEmitPrivateNameCausesError.types # tests/baselines/reference/doubleMixinConditionalTypeBaseClassWorks.types # tests/baselines/reference/emitClassExpressionInDeclarationFile.types # tests/baselines/reference/emitClassExpressionInDeclarationFile2.types # tests/baselines/reference/exportClassExtendingIntersection.types # tests/baselines/reference/mixinAbstractClasses.2.types # tests/baselines/reference/mixinAbstractClasses.types # tests/baselines/reference/mixinAbstractClassesReturnTypeInference.types # tests/baselines/reference/mixinClassesAnnotated.types # tests/baselines/reference/mixinClassesAnonymous.types # tests/baselines/reference/mixinIntersectionIsValidbaseType.types # tests/baselines/reference/mixinOverMappedTypeNoCrash.types # tests/baselines/reference/mixinPrivateAndProtected.types # tests/baselines/reference/mixingApparentTypeOverrides.types # tests/baselines/reference/noCrashOnMixin.types # tests/baselines/reference/overrideBaseIntersectionMethod.types # tests/baselines/reference/typeAliasFunctionTypeSharedSymbol.types
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
github-project-automation
bot
moved this from Waiting on reviewers
to Done
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #57317
this is different from #49863 - that PR likely still has a bug that I'm fixing here because it would replace the outer type parameter with its constraint