Skip to content

Exclude undefined from constraints of mapped type type parameters#59995

Closed
Andarist wants to merge 1 commit intomicrosoft:mainfrom
Andarist:fix/exclude-undefined-from-mapped-constraint
Closed

Exclude undefined from constraints of mapped type type parameters#59995
Andarist wants to merge 1 commit intomicrosoft:mainfrom
Andarist:fix/exclude-undefined-from-mapped-constraint

Conversation

@Andarist
Copy link
Copy Markdown
Contributor

@Andarist Andarist commented Sep 17, 2024

fixes #59987

see @ahejlsberg's comment here about homomorphic mapped types and their constraints

given that keyof X (and the same is true about [K in ...]) should never include undefined, I think it should be fairly OK to eliminate undefined from such rogue instantiations that might happen

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 17, 2024
@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Computed type key inference inconsistent with identical explicitly declared type

3 participants