Skip to content

Python: Prefer runtime kwargs for conversation_id in OpenAI Responses client #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giles17 merged 2 commits into from
Jan 23, 2026
Merged

Python: Prefer runtime kwargs for conversation_id in OpenAI Responses client #3312

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82a1769
prefer kwargs conversation_id over options
giles17 Jan 20, 2026
f181817
addressed comments
giles17 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/packages/core/agent_framework/openai/_responses_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def _check_model_presence(self, options: dict[str, Any]) -> None:

def _get_current_conversation_id(self, options: dict[str, Any], **kwargs: Any) -> str | None:
"""Get the current conversation ID from options dict or kwargs."""
Comment thread
giles17 marked this conversation as resolved.
Outdated
return options.get("conversation_id") or kwargs.get("conversation_id")
return kwargs.get("conversation_id") or options.get("conversation_id")
Comment thread
giles17 marked this conversation as resolved.

def _prepare_messages_for_openai(self, chat_messages: Sequence[ChatMessage]) -> list[dict[str, Any]]:
"""Prepare the chat messages for a request.
Expand Down
Loading