Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds runnable Neo4j GraphRAG samples to both the Python and .NET sample sets, using the published Neo4j provider packages and wiring the new .NET sample into the existing AgentWithRAG sample lineup/solution.
Changes:
- Add a Python Neo4j GraphRAG context-provider sample (
neo4j_graphrag) runnable viauv run(PEP 723 inline deps). - Add a .NET Neo4j GraphRAG RAG sample project (
AgentWithRAG_Step05_Neo4jGraphRAG) and include it in the AgentWithRAG index + solution. - Pin Neo4j sample package versions via central package management and exclude the Python sample from pyright sample configs.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| python/samples/02-agents/context_providers/neo4j_graphrag/README.md | Documents the new Python Neo4j GraphRAG sample, prerequisites, and env vars. |
| python/samples/02-agents/context_providers/neo4j_graphrag/main.py | Implements the runnable Python GraphRAG sample (Foundry chat client + Neo4j context provider). |
| python/pyrightconfig.samples.py310.json | Excludes the new sample path from pyright sample checking. |
| python/pyrightconfig.samples.json | Excludes the new sample path from pyright sample checking. |
| dotnet/samples/02-agents/AgentWithRAG/README.md | Adds the Neo4j GraphRAG sample entry to the AgentWithRAG index. |
| dotnet/samples/02-agents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/README.md | Documents the new .NET Neo4j GraphRAG sample setup and run steps. |
| dotnet/samples/02-agents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/Program.cs | Implements the .NET GraphRAG sample (Azure OpenAI + Neo4j provider). |
| dotnet/samples/02-agents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/AgentWithRAG_Step05_Neo4jGraphRAG.csproj | Defines the new sample project and its package references. |
| dotnet/Directory.Packages.props | Adds centrally-managed versions for Neo4j packages used by the sample. |
| dotnet/agent-framework-dotnet.slnx | Adds the new sample project to the solution index. |
python/samples/02-agents/context_providers/neo4j_graphrag/main.py
Outdated
Show resolved
Hide resolved
dotnet/samples/02-agents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/Program.cs
Show resolved
Hide resolved
...ents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/AgentWithRAG_Step05_Neo4jGraphRAG.csproj
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Mar 31, 2026
westey-m
reviewed
Mar 31, 2026
...ents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/AgentWithRAG_Step05_Neo4jGraphRAG.csproj
Outdated
Show resolved
Hide resolved
Member
eavanvalkenburg
left a comment
There was a problem hiding this comment.
couple of notes on the python version, nothing major
python/samples/02-agents/context_providers/neo4j_graphrag/main.py
Outdated
Show resolved
Hide resolved
python/samples/02-agents/context_providers/neo4j_graphrag/main.py
Outdated
Show resolved
Hide resolved
python/samples/02-agents/context_providers/neo4j_graphrag/main.py
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Mar 31, 2026
...ents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/AgentWithRAG_Step05_Neo4jGraphRAG.csproj
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Mar 31, 2026
eavanvalkenburg
approved these changes
Mar 31, 2026
Member
eavanvalkenburg
left a comment
There was a problem hiding this comment.
the python side looks good, thanks @ltwlf one note on the neo4j package, we have embedding clients in MAF as well, could be reused in your package.
westey-m
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python/samples/02-agents/context_providers/neo4j_graphragAgentWithRAG_Step05_Neo4jGraphRAGNeo4j.AgentFramework.GraphRAGandagent-framework-neo4jpackages rather than repo-local integrationsWhy
A previous Neo4j context-provider PR existed, but it was documentation-only
Validation
python3 -m py_compile python/samples/02-agents/context_providers/neo4j_graphrag/main.pyuv run /Users/ltwlf/Sources/ltwlf/agent-framework/python/samples/02-agents/context_providers/neo4j_graphrag/main.pydotnet build dotnet/samples/02-agents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/AgentWithRAG_Step05_Neo4jGraphRAG.csproj -c Debugdotnet run --framework net10.0 --project dotnet/samples/02-agents/AgentWithRAG/AgentWithRAG_Step05_Neo4jGraphRAG/AgentWithRAG_Step05_Neo4jGraphRAG.csprojNUGET_PACKAGES=$(mktemp -d) dotnet restore ... --configfile dotnet/nuget.configNotes
uv runworks directly.