Add search-bar powered by local search index#7031
Closed
yujonglee wants to merge 1 commit intomicrosoft:masterfrom
Closed
Add search-bar powered by local search index#7031yujonglee wants to merge 1 commit intomicrosoft:masterfrom
yujonglee wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
awentzel
approved these changes
Oct 15, 2024
Collaborator
|
Hi @yujonglee, appreciate the PR but it looks like the documentation site (https://getcanary.dev/) for these packages is giving a 404, there is no README on npm registry (https://www.npmjs.com/package/@getcanary/docusaurus-theme-search-pagefind) and I can't be sure where the code is located. I will close this for now, feel free to re-open once these issues are resolved. I do believe this is the correct approach however we must be able to do our due diligence on code security.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request
Add search bar to the documentation site.
📖 Description
Currently, the documentation site does not have a search bar.
I implemented a search bar using:
Both are MIT licensed.
Video:
(Colors are configurable in the Docusaurus config)
Screen.Recording.2024-10-12.at.9.05.09.PM.mov
Notes:
npm run buildat least once, before runningnpm run start. Because Pagefind index is generated in production build.🎫 Issues
None
👩💻 Reviewer Notes
None
📑 Test Plan
None
✅ Checklist
General
$ npm run change⏭ Next Steps
None