Merged
Conversation
alloy
force-pushed
the
alloy/supermassive-packages-fixes
branch
from
f9fdee8 to
064ea8a
Compare
alloy
changed the title
alloy
commented
Apr 1, 2022
| { | ||
| "name": "supermassive-todomvc", | ||
| "main": "index.js", | ||
| "private": true, |
Member
Author
There was a problem hiding this comment.
CI just pushed this package to public npm 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current
mainthe TS dep is listed as ^4.4.3 , but then it uses a compiler API, which was changed in a breaking manner in TS 4.5, but it uses it in the old manner—i.e. it passes 2 arguments instead of 3. For now pinning supermassive to < 4.5, but we should probably be consistent and on latest.