[node-api|node-addon-api] fix and update#29599
Merged
JavierMatosD merged 11 commits intomicrosoft:masterfrom Feb 14, 2023
Merged
[node-api|node-addon-api] fix and update#29599JavierMatosD merged 11 commits intomicrosoft:masterfrom
JavierMatosD merged 11 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.gh.lumenfield.work/in/15368?s=60&v=4){kind=small}
dg0yt
reviewed
Feb 11, 2023
MonicaLiu0311
added
category:port-bug
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for node-addon-api have changed but the version was not updated
version: 6.0.0
old SHA: 91aef4815b3f861cd00b389fe6760e468c283d29
new SHA: 45cf82eea2cea9f8fa60b8a476f6484f75f81ca5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Contributor
Author
|
@dg0yt @MonicaLiu0311 ready tested with my test project https://github.com/Pospelove/napi-test |
MonicaLiu0311
approved these changes
Feb 14, 2023
MonicaLiu0311
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_packagecall (previously lead to cmake error)