Skip to content

fix: npm audit - fix high severity vulnerabilities#8601

Closed
Copilot wants to merge 5 commits intomainfrom
copilot/npm-audit-fix
Closed

fix: npm audit - fix high severity vulnerabilities#8601
Copilot wants to merge 5 commits intomainfrom
copilot/npm-audit-fix

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

Summary

Addresses security vulnerabilities found by npm audit.

Changes

  • Updated terser-webpack-plugin from 5.1.1 to 5.4.0 (fixes serialize-javascript vulnerability in its dependency tree)
  • Added overrides in package.json to force a fixed sub-dependency version:
    • serialize-javascript@7.0.4 (fixes GHSA-5c6j-r48x-rmvq — RCE via RegExp.flags / Date.prototype.toISOString(), was <=7.0.2)
  • Added engines.node: ">=20" to package.json to reflect the Node 20 requirement introduced by serialize-javascript@7.0.4

Result

Before After
8 vulnerabilities (5 low, 3 high) 6 low severity vulnerabilities

The remaining low-severity vulnerabilities are:


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI and others added 2 commits March 18, 2026 17:35
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
@rzhao271 rzhao271 marked this pull request as ready for review March 18, 2026 17:40
Copilot AI review requested due to automatic review settings March 18, 2026 17:40
@rzhao271 rzhao271 added this to the 1.113.0 milestone Mar 18, 2026
@rzhao271 rzhao271 enabled auto-merge (squash) March 18, 2026 17:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce high-severity npm audit findings by updating build tooling dependencies and pinning patched transitive dependency versions via package.json overrides.

Changes:

  • Bumped terser-webpack-plugin from 5.1.1 to 5.4.0.
  • Added package.json overrides to force patched versions of serialize-javascript and diff.
  • Updated package-lock.json to reflect the new dependency graph; also includes a small proposed VS Code typings update.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/@types/vscode.proposed.chatSessionsProvider.d.ts Updates JSDoc/parameter naming for a proposed VS Code chat sessions provider API.
package.json Updates terser-webpack-plugin and adds overrides for vulnerable transitive deps.
package-lock.json Lockfile regeneration reflecting the dependency/override changes (incl. diff/serialize-javascript/terser* updates).

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mjbvz
mjbvz previously approved these changes Mar 18, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rzhao271
Copy link
Contributor

@copilot install dependencies again to fix build

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 18, 2026

@copilot install dependencies again to fix build

Done — ran npm install to sync package-lock.json with the current package.json state (commit a720612).

@rzhao271 rzhao271 closed this Mar 18, 2026
auto-merge was automatically disabled March 18, 2026 22:40

Pull request was closed

@rzhao271 rzhao271 reopened this Mar 18, 2026
@rzhao271
Copy link
Contributor

Closing and trying again.

@rzhao271 rzhao271 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants