You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run tests in the file (Cmd/Ctrl+; F) and commit the change when they pass.
Note that the function now conveniently returns a DisposableStore for you to use, and you'll be pleased to see that reporting of undisposed resources in-editor have been dramatically improved since the first issue was created. In simple cases where tests already clean up nicely, you should be able to add the function call and move on 🙂
Files lacking the call, based on the last person who touched them:
This is round two of #190503, with slightly updated instructions:
code-ensure-no-disposables-leak-in-testexclusions in .eslintrc.json.ensureNoDisposablesAreLeakedInTestSuitein unit tests #190503Cmd/Ctrl+; F) and commit the change when they pass.Note that the function now conveniently returns a DisposableStore for you to use, and you'll be pleased to see that reporting of undisposed resources in-editor have been dramatically improved since the first issue was created. In simple cases where tests already clean up nicely, you should be able to add the function call and move on 🙂
Files lacking the call, based on the last person who touched them:
src/vs/workbench/test/browser/quickAccess.test.tstracking in AdoptensureNoDisposablesAreLeakedInTestSuiteinquickAccess.test.ts#204205