Allow JsonSerializerOptions parameters for user-defined and inputs and hardcode everything else to the source generator.#182
Merged
eiriktsarpalis merged 4 commits intomodelcontextprotocol:mainfrom Apr 2, 2025
Conversation
0e8c530 to
0b2a071
Compare
stephentoub
reviewed
Apr 2, 2025
stephentoub
reviewed
Apr 2, 2025
stephentoub
reviewed
Apr 2, 2025
…and hardcode everything else to the source generator.
69b3c77 to
becdd3e
Compare
halter73
approved these changes
Apr 2, 2025
halter73
reviewed
Apr 2, 2025
This was referenced Jul 24, 2025
Contributor
|
Adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the JSON serialization aspects of the
IMcpClientandIMcpServerabstractions in the following ways:IMcpEndpointsignature by making itsSendRequestAsyncnon generic.JsonSerializerOptionsoverload that can be used to override serialization settings.