Skip to content

Update URL validation to allow file and other nonstandard schemas#207

Merged
jspahrsummers merged 1 commit intomodelcontextprotocol:mainfrom
hmwildermuth:main
Feb 13, 2025
Merged

Update URL validation to allow file and other nonstandard schemas#207
jspahrsummers merged 1 commit intomodelcontextprotocol:mainfrom
hmwildermuth:main

Conversation

@hmwildermuth
Copy link
Copy Markdown
Contributor

Update URL validation to allow file and other nonstandard schemas

Motivation and Context

See #86 - this was breaking some servers including the example simple-resource server.

How Has This Been Tested?

Simple resource server now working locally, both ListResources and ReadResources

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Copy Markdown
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@jspahrsummers jspahrsummers merged commit 5480f67 into modelcontextprotocol:main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants