Skip to content

feat(stage-ui): add missing icon for gaming-factorio module#1130

Merged
nekomeowww merged 2 commits intomoeru-ai:mainfrom
lietblue:factorio-icon-improvement
Mar 5, 2026
Merged

feat(stage-ui): add missing icon for gaming-factorio module#1130
nekomeowww merged 2 commits intomoeru-ai:mainfrom
lietblue:factorio-icon-improvement

Conversation

@lietblue
Copy link
Contributor

@lietblue lietblue commented Mar 5, 2026

Summary

  • The gaming-factorio module entry in the modules list had no icon since it was first added
  • Added factorio-simple.png — a monochrome silhouette derived from the existing game asset in apps/stage-pocket
  • Used iconImage to display it, consistent with how other modules without iconify coverage handle icons

Changes

  • packages/stage-ui/src/assets/factorio.png — original asset (copied from apps/stage-pocket)
  • packages/stage-ui/src/assets/factorio-simple.png — processed monochrome version used in UI
  • packages/stage-ui/src/composables/use-modules-list.ts — add iconImage to factorio module entry

Notes

simple-icons and vscode-icons do not include a Factorio icon, so iconImage is used instead of icon/iconColor.

Screenshot

image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user interface by providing a visual identifier for the 'gaming-factorio' module. By integrating a custom icon, the module list achieves greater consistency and improves the overall user experience, especially for modules that do not have readily available icons through standard icon libraries.

Highlights

  • Missing Icon Added: The 'gaming-factorio' module now displays a dedicated icon, addressing a previous omission in the modules list.
  • Custom Icon Implementation: A monochrome silhouette of the Factorio icon, derived from an existing game asset, has been added to the UI.
  • Consistent Icon Handling: The iconImage property is utilized for displaying the icon, aligning with how other modules without direct Iconify support manage their visual representation.
Changelog
  • packages/stage-ui/src/composables/use-modules-list.ts
    • Imported the new 'factorio-simple.png' asset.
    • Assigned the imported icon to the 'iconImage' property of the 'gaming-factorio' module entry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds the missing icon for the gaming-factorio module. The changes are straightforward, correctly importing the factorio-simple.png asset and assigning it to the iconImage property of the module entry, consistent with the Module interface and how other modules without Iconify coverage are handled. The implementation is clean and directly addresses the stated problem without introducing any new issues.

@lietblue
Copy link
Contributor Author

lietblue commented Mar 5, 2026

等下这个有问题 它不应该推那个老image 我修改一下

@lietblue lietblue force-pushed the factorio-icon-improvement branch from 311e473 to 1a9dd81 Compare March 5, 2026 06:46
@lietblue
Copy link
Contributor Author

lietblue commented Mar 5, 2026

ok 没有问题 修了

@nekomeowww nekomeowww merged commit e1ba966 into moeru-ai:main Mar 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants