fix(stage-web,stage-tamagotchi): i18n#246
Conversation
✅ Deploy Preview for airi-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @liliumneko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on improving the internationalization (i18n) of the application, with a significant emphasis on refining the Chinese (zh-CN) locale. I've updated terminology for clarity, added comprehensive localized explanations for various service providers, and integrated new provider-specific guidance. The changes also include preparing the UI for new provider integrations by adding their respective localization keys and ensuring existing UI components correctly utilize the i18n framework.
Highlights
- Terminology Refinement (Chinese): I've updated the Chinese localization files (
zh-CN.yml) across bothstage-tamagotchiandstage-webapplications to consistently replace the term "提供商" (provider) with "服务来源" (service source/origin). This change also extends to theREADME.zh-CN.mddocumentation, ensuring a more precise and consistent vocabulary for describing service integrations. - Enhanced Provider Explanations and Onboarding: I've introduced new localization keys in both English (
en.yml) and Chinese (zh-CN.yml) to provide clearer explanations for different types of providers (Chat, Speech, Transcription). Additionally, a new 'First time here?' help section has been added to guide users, particularly for configuring chat providers, which are essential for the system's core functionality. - New Provider Localizations and Guidance: I've added localization entries for several new providers, including
app-local-audio-speech,browser-local-audio-speech,google-generative-ai,featherless, andplayer2. Crucially, I've also included specifichelpinfofor the Anthropic provider in both languages, detailing potential CORS restrictions and suggesting proxy solutions, and updated the Anthropic settings page to use these new localized strings. - UI Internationalization Integration: The
providers/index.vuecomponent has been updated to leveragevue-i18nfor displaying the new provider explanations and onboarding messages, replacing previously hardcoded English strings. This ensures that these informative texts are properly localized based on the user's selected language.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request focuses on internationalization (i18n) by replacing hardcoded strings with localization keys and updating Chinese translations. I've provided feedback on improving code consistency, correcting typos, and enhancing code maintainability.
| <i18n-t keypath="settings.pages.providers.helpinfo.description"> | ||
| <template #chat> | ||
| <span class="inline-flex translate-y-[0.25lh] items-center gap-1 rounded-lg bg-primary-500/10 px-2 py-0.5 dark:bg-primary-800/25"> | ||
| <div class="i-solar:chat-square-like-bold-duotone" /> | ||
| <strong class="font-semibold">Chat</strong> | ||
| </span> | ||
| </template> | ||
| </i18n-t> |
There was a problem hiding this comment.
Consider using a single i18n-t component with a slot for the Chat text to avoid redundant code and improve maintainability.
| <span text="neutral-300 dark:neutral-500">{{ t('settings.pages.providers.explained.Speech') }}</span> | ||
| </div> |
There was a problem hiding this comment.
Consider using a single i18n-t component with a slot for the Speech text to avoid redundant code and improve maintainability.
| <div> | ||
| <div> | ||
| <span text="neutral-300 dark:neutral-500">Transcription (speech-to-text) model providers. e.g. Whisper.cpp, OpenAI, Azure Speech</span> | ||
| <span text="neutral-300 dark:neutral-500">{{ t('settings.pages.providers.explained.Transcription') }}</span> |
There was a problem hiding this comment.
Consider using a single i18n-t component with a slot for the Transcription text to avoid redundant code and improve maintainability.
3 participants
No description provided.