fix: pwa service worker registering

[typed-sigterm]

Description

Linked Issues

Resolve #281

Additional context

[netlify]

✅ Deploy Preview for airi-docs ready!

Name	Link
🔨 Latest commit	d9d941b
🔍 Latest deploy log	https://app.netlify.com/projects/airi-docs/deploys/687b1b91be0e9b0008350359
😎 Deploy Preview	https://deploy-preview-299--airi-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[gemini-code-assist]

Summary of Changes

Hello @typed-sigterm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a reported issue with PWA (Progressive Web App) service worker registration. The core change involves adjusting the Vite build configuration to correctly handle the PWA registration module, which should enable proper service worker functionality for the application.

Highlights

• PWA Configuration Fix: I've removed the virtual:pwa-register entry from the build.rollupOptions.external configuration in vite.config.ts. This change is intended to ensure that the PWA registration module is correctly bundled by Vite, which should resolve issues related to service worker registration.
• Configuration Cleanup: I've also removed an unnecessary and empty server object from the Vite configuration file, cleaning up the vite.config.ts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[netlify]

✅ Deploy Preview for airi-vtuber ready!

Name	Link
🔨 Latest commit	d9d941b
🔍 Latest deploy log	https://app.netlify.com/projects/airi-vtuber/deploys/687b1b9111d4c900083d92ef
😎 Deploy Preview	https://deploy-preview-299--airi-vtuber.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue with the Progressive Web App (PWA) service worker registration by removing an erroneous Rollup configuration. The change ensures that the virtual:pwa-register module is properly bundled by Vite's PWA plugin. The removal of an empty server configuration block is also a good cleanup. The changes are straightforward and look good.

[nekomeowww]

But for HuggingFace Spaces, PWA isn't helpful. I used to encounter some issues over there. We can try this for one time to see if HFS did some fix on this.

[nekomeowww]

Oh, interesting! Thanks.

[nekomeowww]

What is Acked-by?

[nekomeowww]

Oh...

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Acked-by: is meant to be used by those responsible for or involved with the affected code in one way or another. Most commonly, the maintainer when that maintainer neither contributed to nor forwarded the patch.

Acked-by: may also be used by other stakeholders, such as people with domain knowledge (e.g. the original author of the code being modified), userspace-side reviewers for a kernel uAPI patch or key users of a feature. Optionally, in these cases, it can be useful to add a “# Suffix” to clarify its meaning:

Acked-by means acker has at least reviewed the patch and has indicated acceptance. More details can be found in https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

• Signed-off-by: certifies that you wrote it or otherwise have the right to
  pass it on as a open-source patch.
• Acked-by: If a person was not directly involved in the preparation or
  handling of a patch but wishes to signify and record their approval
  of it then they can arrange to have an Acked-by: line. Acked-by:
  does not necessarily indicate acknowledgement of the entire patch.
• Tested-by: A Tested-by: tag indicates that the patch has been successfully
  tested (in some environment) by the person named. This tag informs
  maintainers that some testing has been performed, provides a means to locate
  testers for future patches, and ensures credit for the testers.
• Reviewed-by: A Reviewed-by tag is a statement of opinion that the patch is an
  appropriate modification of the kernel without any remaining
  serious technical issues. Any interested reviewer (who has done
  the work) can offer a Reviewed-by tag for a patch.

Ref:

• https://forum.linuxfoundation.org/discussion/864213/can-anyone-explain-acked-by-with-an-example

Learned so many, thanks!