feat: improve status indicator accessibility in settings#441
feat: improve status indicator accessibility in settings#441typed-sigterm merged 4 commits intomoeru-ai:mainfrom
Conversation
- Replace subtle green/gray dots with more distinct checkmark/empty circle - Add checkmark icon for configured modules (green circle with white check) - Use light gray hollow circle for unconfigured modules - Increase indicator size from size-3 to size-4 for better visibility - Improve color contrast and visual semantics for accessibility
✅ Deploy Preview for airi-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Arjunmehta312, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the accessibility and visual clarity of status indicators within the modules settings page. The primary goal is to improve the user experience by replacing subtle color-based cues with more distinct and universally understandable symbols. This ensures that the status of modules is immediately clear to all users, including those with color vision deficiencies, without relying solely on color differences.
Highlights
- Enhanced Visual Distinction: The previous subtle green/gray dots have been replaced with more distinct and universally recognizable symbols, improving visual differentiation for all users.
- Improved Configured State Indicator: Configured modules now display a green circle with a white checkmark icon, providing a clear and intuitive 'completed' visual cue.
- Clear Unconfigured State Indicator: Unconfigured modules are now represented by a light gray hollow circle, clearly signifying an 'incomplete' or 'to-do' status.
- Increased Indicator Size: The size of the status indicators has been increased from
size-3tosize-4, enhancing their overall visibility on the page. - Accessibility Focus: The changes significantly improve color contrast and visual semantics, addressing accessibility concerns by moving beyond sole reliance on color for conveying status.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the accessibility of the module status indicators by using more distinct visual cues. The change from simple colored dots to a checkmark and a hollow circle is a great step forward. My review focuses on further refining the implementation for better code quality and ensuring the new indicators meet accessibility contrast standards.
|
I wouldn't say align the indicator to center to be the better approach... should we improve that? And perhaps, screenshots can be added? |
|
Maybe off [🌑] and on [✓ in ⭕] are more discerning |
|
These are the screenshots of my fix |
typed-sigterm
changed the title
Co-authored-by: Typed SIGTERM <typed.sigterm@gmail.com>
Co-authored-by: Typed SIGTERM <typed.sigterm@gmail.com>
3 participants
Replace subtle green/gray dots with more distinct checkmark/empty circle
Description
This PR addresses accessibility issues with the status indicators in the modules settings page. The previous implementation used subtle color variations (green vs gray filled circles) that were difficult to distinguish, especially for users with color vision difficulties.
Before:
After:
The new design uses universal visual symbols (checkmark = done, empty circle = to-do) and provides much better contrast, making the status immediately clear without relying solely on color differences.
Linked Issues
Fixes #292
Additional Context
i-solar:check-boldicon to maintain consistency with the project's icon systemIconStatusItemcomponentPlease focus on verifying that the new indicators are clearly distinguishable and provide better accessibility for all users.