Skip to content

feat(nix): auto-update pnpmDeps hash#490

Merged
nekomeowww merged 1 commit intomoeru-ai:mainfrom
Weathercold:update-nix-pnpm-deps-hash-action
Aug 28, 2025
Merged

feat(nix): auto-update pnpmDeps hash#490
nekomeowww merged 1 commit intomoeru-ai:mainfrom
Weathercold:update-nix-pnpm-deps-hash-action

Conversation

@Weathercold
Copy link
Collaborator

Description

I didn't test the action
The assets hash still needs to be manually updated

Linked Issues

Additional Context

@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for airi-docs ready!

Name Link
🔨 Latest commit 97a563c
🔍 Latest deploy log https://app.netlify.com/projects/airi-docs/deploys/68ae2be6088a720008eeec75
😎 Deploy Preview https://deploy-preview-490--airi-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for airi-vtuber ready!

Name Link
🔨 Latest commit 97a563c
🔍 Latest deploy log https://app.netlify.com/projects/airi-vtuber/deploys/68ae2be4b8c5d400084903a3
😎 Deploy Preview https://deploy-preview-490--airi-vtuber.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Weathercold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the process of updating pnpmDeps hashes within the Nix build system. It achieves this by refactoring the Nix configuration, moving the package.nix file into a dedicated nix/ directory, and externalizing the pnpmDeps hash into a separate file (nix/pnpm-deps-hash.txt). A new shell script is introduced to automatically generate and update this hash, streamlining dependency management. The author notes that the action itself hasn't been tested and the assets hash still requires manual updates.

Highlights

  • Nix Configuration Refactoring: Moved package.nix to nix/package.nix and updated references in flake.nix to centralize Nix-related files.
  • Automated pnpmDeps Hash Management: The pnpmDeps hash is now read from nix/pnpm-deps-hash.txt instead of being hardcoded, enabling dynamic updates.
  • Hash Update Script: Introduced nix/update-pnpm-deps-hash.sh, a new script that automates the process of clearing and updating the pnpmDeps hash by building the airi.pnpmDeps derivation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to automatically update the pnpmDeps hash for the Nix build by using a script. This is a great improvement for maintainability, as it automates a previously manual step. The changes to flake.nix and nix/package.nix are correct to support this new structure. I have one suggestion for the new update-pnpm-deps-hash.sh script to make it more robust against silent failures. Overall, a good change.

@Weathercold Weathercold force-pushed the update-nix-pnpm-deps-hash-action branch from 7eb38c4 to 97a563c Compare August 26, 2025 21:49
Comment on lines +5 to +9
push:
branches:
- main
paths:
- 'pnpm-lock.yaml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this in cron hours? Otherwise each commit about pnpm-lock.yaml will produce one extra automated commit.

@sumimakito do you have any experience on similar thing to this? Perhaps cascading updating something based on changes, would love to hear from best practice.

Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest is LGTM.

@nekomeowww
Copy link
Member

Or perhaps, we can achieve this through a postinstall hook? In such case, we could write script to do post release to update the versions for Nix as well when using bumpp to release new versions.

I wrote on for updating Cargo.toml when releasing new things here

airi/bump.config.ts

Lines 15 to 44 in 252ca8e

execute: async () => {
const cargoTomlFile = await readFile(join(cwd(), 'Cargo.toml'))
const cargoToml = parse(cargoTomlFile.toString('utf-8')) as {
workspace?: {
package?: {
version?: string
}
}
}
if (typeof cargoToml !== 'object' || cargoToml === null) {
throw new TypeError('Cargo.toml does not contain a valid object')
}
if (typeof cargoToml.workspace?.package?.version !== 'string') {
throw new TypeError('Cargo.toml does not contain a valid version in workspace.package.version')
}
const packageJSONFile = join(cwd(), 'package.json')
const packageJSON = JSON.parse(await readFile(packageJSONFile, 'utf-8'))
if (typeof packageJSON?.version !== 'string' || packageJSON?.version === null) {
throw new TypeError('package.json does not contain a valid version')
}
cargoToml.workspace.package.version = packageJSON.version
console.log(`Bumping Cargo.toml version to ${cargoToml.workspace.package.version} (from package.json, ${packageJSON.version})`)
await writeFile(join(cwd(), 'Cargo.toml'), stringify(cargoToml))
await execa('cargo', ['generate-lockfile'])
},
})

@Weathercold
Copy link
Collaborator Author

Or perhaps, we can achieve this through a postinstall hook? In such case, we could write script to do post release to update the versions for Nix as well when using bumpp to release new versions.

I wrote on for updating Cargo.toml when releasing new things here

airi/bump.config.ts

Lines 15 to 44 in 252ca8e

execute: async () => {
const cargoTomlFile = await readFile(join(cwd(), 'Cargo.toml'))
const cargoToml = parse(cargoTomlFile.toString('utf-8')) as {
workspace?: {
package?: {
version?: string
}
}
}
if (typeof cargoToml !== 'object' || cargoToml === null) {
throw new TypeError('Cargo.toml does not contain a valid object')
}
if (typeof cargoToml.workspace?.package?.version !== 'string') {
throw new TypeError('Cargo.toml does not contain a valid version in workspace.package.version')
}
const packageJSONFile = join(cwd(), 'package.json')
const packageJSON = JSON.parse(await readFile(packageJSONFile, 'utf-8'))
if (typeof packageJSON?.version !== 'string' || packageJSON?.version === null) {
throw new TypeError('package.json does not contain a valid version')
}
cargoToml.workspace.package.version = packageJSON.version
console.log(`Bumping Cargo.toml version to ${cargoToml.workspace.package.version} (from package.json, ${packageJSON.version})`)
await writeFile(join(cwd(), 'Cargo.toml'), stringify(cargoToml))
await execa('cargo', ['generate-lockfile'])
},
})

Unfortunately, since the nix flake uses the latest git commit, it'll be outdated as soon as a commit modifies pnpm-lock.yaml

What about a precommit hook along with an updated workflow that doesn't run if the hash is changed? Or throttling the workflow?

@nekomeowww
Copy link
Member

Ok I understand it now.

@nekomeowww nekomeowww merged commit 525964b into moeru-ai:main Aug 28, 2025
14 checks passed
@nekomeowww
Copy link
Member

It works a817111

lucas-oma pushed a commit to lucas-oma/airi that referenced this pull request Sep 7, 2025
@Weathercold Weathercold deleted the update-nix-pnpm-deps-hash-action branch September 11, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants