Skip to content

fix(stage-web): reduce saturation#75

Merged
nekomeowww merged 4 commits intomainfrom
dev/fix-theme-color
Mar 12, 2025
Merged

fix(stage-web): reduce saturation#75
nekomeowww merged 4 commits intomainfrom
dev/fix-theme-color

Conversation

@luoling8192
Copy link
Member

@luoling8192 luoling8192 commented Mar 12, 2025

depends #74

@luoling8192 luoling8192 changed the title feat(stage-web): theme presets fix(stage-web): reduce saturation Mar 12, 2025
@netlify
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for airi-docs ready!

Name Link
🔨 Latest commit c71e5f7
🔍 Latest deploy log https://app.netlify.com/sites/airi-docs/deploys/67d1c89be34a520008cb9a7f
😎 Deploy Preview https://deploy-preview-75--airi-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for airi-vtuber ready!

Name Link
🔨 Latest commit c71e5f7
🔍 Latest deploy log https://app.netlify.com/sites/airi-vtuber/deploys/67d1c89b02184f0008708c20
😎 Deploy Preview https://deploy-preview-75--airi-vtuber.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@luoling8192 luoling8192 requested a review from Copilot March 12, 2025 17:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reduces saturation across the stage-web application by adjusting color conversions and updating theme-related components. Key changes include adding a new utility function for converting hex colors to OKLCH, incorporating theme color presets in the settings page, and updating background components to reflect the reduced saturation.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
apps/stage-web/src/utils/color.ts New OKLCH conversion function with adjustments for saturation
apps/stage-web/src/pages/settings/themes/index.vue Adds theme color presets and integrates the new color conversion into settings
apps/stage-web/src/pages/index.vue Replaces AnimatedBackground with AnimatedWave and updates fill-color formulas
apps/stage-web/src/components/Backgrounds/Cross.vue Updates CSS custom properties using calc for adjusting saturation
Comments suppressed due to low confidence (2)

apps/stage-web/src/utils/color.ts:16

  • Consider validating that the hex string has exactly 6 characters after removing any leading '#' to avoid potential runtime errors with incorrect input formats.
hex = hex.replace('#', '')

apps/stage-web/src/utils/color.ts:48

  • [nitpick] Consider renaming 'b2' to something more descriptive such as 'labB' to better indicate that it represents the Lab 'b' component, distinguishing it from the blue channel variable.
const b2 = 200 * (fy - fz)

@luoling8192 luoling8192 force-pushed the dev/fix-theme-color branch from b6273d2 to 4406d1b Compare March 12, 2025 17:43
@luoling8192 luoling8192 force-pushed the dev/fix-theme-color branch from 4406d1b to c71e5f7 Compare March 12, 2025 17:47
@nekomeowww nekomeowww merged commit 6fcb746 into main Mar 12, 2025
11 checks passed
@nekomeowww nekomeowww deleted the dev/fix-theme-color branch March 12, 2025 18:27
Disqort pushed a commit to Disqort/airi that referenced this pull request Aug 29, 2025
* feat(stage-web): theme presets
* refactor: use @culorijs to convert color
* fix: brush
* fix(stage-web): reduce saturation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants