Skip to content

fix(stage-ui): AIRI in full resolution! fixed pixi.js resolution issue#808

Merged
nekomeowww merged 1 commit intomoeru-ai:mainfrom
shinohara-rin:sr/resolution-fix
Dec 17, 2025
Merged

fix(stage-ui): AIRI in full resolution! fixed pixi.js resolution issue#808
nekomeowww merged 1 commit intomoeru-ai:mainfrom
shinohara-rin:sr/resolution-fix

Conversation

@shinohara-rin
Copy link
Contributor

@shinohara-rin shinohara-rin commented Dec 16, 2025

No more blurry live2d models on HDPI screens!

image image

Yes it also works on tamagotchi

Screenshot 2025-12-17 at 10 12 21 AM

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shinohara-rin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves the issue of blurry Live2D models on high-DPI displays by refining the PixiJS rendering configuration. The changes ensure that the application's internal rendering resolution and the scaling of the Live2D stage are precisely aligned with the device's pixel density, leading to a significantly clearer and sharper visual experience for users with HDPI screens.

Highlights

  • Enhanced Resolution for Live2D Models: Implemented explicit resolution handling for PixiJS, ensuring Live2D models render sharply on high-DPI (HDPI) screens by correctly scaling the internal rendering buffer and stage content.
  • PixiJS Configuration Update: Modified the PixiJS application initialization to disable autoDensity and set the base resolution to 1, allowing for manual control over rendering quality.
  • Refactored Resize Logic: Updated the handleResize function to dynamically adjust the PixiJS renderer's internal dimensions and the stage's scale based on props.resolution, streamlining how resolution changes are managed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses blurry Live2D models on HDPI screens by changing the rendering strategy. Instead of relying on PixiJS's resolution property, it now manually creates a larger canvas and scales the stage. This is a solid and common approach for achieving crisp rendering on high-resolution displays. The implementation is consistent and correct. I've added one suggestion to combine related property watchers into a single one, which will improve code clarity and maintainability.

@shinohara-rin
Copy link
Contributor Author

However... this also introduces more render load, and it kinda lags on low-power devices. It's a good idea to make this toggleable in the settings.

Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't try this option composition... I tried with many other combos...

@nekomeowww nekomeowww changed the title AIRI in full resolution! fix(stage-ui): AIRI in full resolution! fixed pixi.js resolution issue Dec 17, 2025
@nekomeowww nekomeowww merged commit 588978d into moeru-ai:main Dec 17, 2025
@shinohara-rin
Copy link
Contributor Author

Oh I didn't try this option composition... I tried with many other combos...

This is also 4 hours of consecutive retrying :)

@shinohara-rin shinohara-rin deleted the sr/resolution-fix branch December 17, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants