fix(stage-ui): AIRI in full resolution! fixed pixi.js resolution issue#808
Conversation
Summary of ChangesHello @shinohara-rin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves the issue of blurry Live2D models on high-DPI displays by refining the PixiJS rendering configuration. The changes ensure that the application's internal rendering resolution and the scaling of the Live2D stage are precisely aligned with the device's pixel density, leading to a significantly clearer and sharper visual experience for users with HDPI screens. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses blurry Live2D models on HDPI screens by changing the rendering strategy. Instead of relying on PixiJS's resolution property, it now manually creates a larger canvas and scales the stage. This is a solid and common approach for achieving crisp rendering on high-resolution displays. The implementation is consistent and correct. I've added one suggestion to combine related property watchers into a single one, which will improve code clarity and maintainability.
|
However... this also introduces more render load, and it kinda lags on low-power devices. It's a good idea to make this toggleable in the settings. |
nekomeowww
left a comment
There was a problem hiding this comment.
Oh I didn't try this option composition... I tried with many other combos...
This is also 4 hours of consecutive retrying :) |
No more blurry live2d models on HDPI screens!
Yes it also works on tamagotchi