feat(stage-ui,i18n): added Japanese as language option#856
feat(stage-ui,i18n): added Japanese as language option#856nekomeowww merged 1 commit intomoeru-ai:mainfrom
Conversation
Summary of ChangesHello @taxi13245, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a missing feature where, despite Japanese translations being available via Crowdin, users were unable to select Japanese as their preferred language within the application's settings. By updating the language mapping configuration, this PR ensures that Japanese now appears as a selectable option, allowing users to fully utilize the localized content. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds Japanese as a language option in the settings by updating the languageRemap object. The change is straightforward and functional. The suggestion to remove a redundant mapping to improve code clarity and maintainability has been retained. Overall, this is a good addition to enable Japanese language support.
| 'ja': 'ja', | ||
| 'ja-JP': 'ja', |
There was a problem hiding this comment.
The identity mapping from 'ja' to 'ja' is redundant. The getLanguage function will correctly handle the 'ja' language code even without this entry, so only the 'ja-JP' mapping is necessary. While similar redundancies exist for other languages (e.g., 'en', 'es'), removing this new redundant entry is a good step towards improving code clarity.
'ja-JP': 'ja'
Description
This PR adds Japanese as a selectable language option in the application's language settings.
While Japanese was already added to the Crowdin project, the language selection option was missing from the app's settings screen. As a result, users were unable to switch the app language to Japanese. This PR resolves that issue.
Additional Context
Running
pnpm lint && pnpm typecheckrevealed some pre-existing lint errors (such as formatting issues inCargo.tomland warnings inllm.ts), but these are unrelated to the changes in this PR and have not been addressed here. (It's also possible that these errors are specific to my local environment setup.)