Skip to content

feat(stage-ui,i18n): added Japanese as language option#856

Merged
nekomeowww merged 1 commit intomoeru-ai:mainfrom
taxi13245:AddJapaneseTranslations
Dec 31, 2025
Merged

feat(stage-ui,i18n): added Japanese as language option#856
nekomeowww merged 1 commit intomoeru-ai:mainfrom
taxi13245:AddJapaneseTranslations

Conversation

@taxi13245
Copy link
Contributor

Description

This PR adds Japanese as a selectable language option in the application's language settings.
While Japanese was already added to the Crowdin project, the language selection option was missing from the app's settings screen. As a result, users were unable to switch the app language to Japanese. This PR resolves that issue.

Additional Context

Running pnpm lint && pnpm typecheck revealed some pre-existing lint errors (such as formatting issues in Cargo.toml and warnings in llm.ts), but these are unrelated to the changes in this PR and have not been addressed here. (It's also possible that these errors are specific to my local environment setup.)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taxi13245, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing feature where, despite Japanese translations being available via Crowdin, users were unable to select Japanese as their preferred language within the application's settings. By updating the language mapping configuration, this PR ensures that Japanese now appears as a selectable option, allowing users to fully utilize the localized content.

Highlights

  • Japanese Language Support: Japanese language codes ('ja' and 'ja-JP') have been added to the 'languageRemap' constant, enabling users to select Japanese as an application language in the settings.
Ignored Files
  • Ignored by pattern: packages/i18n/src/** (1)
    • packages/i18n/src/index.ts
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds Japanese as a language option in the settings by updating the languageRemap object. The change is straightforward and functional. The suggestion to remove a redundant mapping to improve code clarity and maintainability has been retained. Overall, this is a good addition to enable Japanese language support.

Comment on lines +31 to +32
'ja': 'ja',
'ja-JP': 'ja',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The identity mapping from 'ja' to 'ja' is redundant. The getLanguage function will correctly handle the 'ja' language code even without this entry, so only the 'ja-JP' mapping is necessary. While similar redundancies exist for other languages (e.g., 'en', 'es'), removing this new redundant entry is a good step towards improving code clarity.

  'ja-JP': 'ja'

@nekomeowww nekomeowww changed the title feat(i18n): Add Japanese language option to settings feat(stage-ui,i18n): added Japanese as language option Dec 31, 2025
@nekomeowww nekomeowww merged commit 60c9175 into moeru-ai:main Dec 31, 2025
@taxi13245 taxi13245 deleted the AddJapaneseTranslations branch December 31, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants