feat(server): system_provider_configs and character_covers#905
feat(server): system_provider_configs and character_covers#905luoling8192 merged 15 commits intomainfrom
system_provider_configs and character_covers#905Conversation
- Created new tables for character bookmarks and likes. - Updated the characters table to include additional fields: avatar_url, character_avatar_url, cover_background_url, creator_role, price_credit, likes_count, bookmarks_count, interactions_count, and forks_count. - Enhanced character schema and service to support liking and bookmarking characters. - Updated API routes to handle like and bookmark actions. - Modified character store to manage likes and bookmarks in the frontend.
…onality - Added @electric-sql/pglite as a dependency for in-memory database testing. - Implemented mock database creation in mock-db.ts to facilitate testing. - Updated character service and routes tests to utilize the new mock database. - Removed outdated character tests and replaced them with updated tests using the mock database. - Enhanced character creation and retrieval tests to validate new schema fields.
- Added a new table for provider configurations in the database. - Created API routes for managing provider configurations, including CRUD operations. - Developed a provider service to handle business logic related to provider configurations. - Implemented validation schemas for provider configuration requests. - Added tests for provider service and routes to ensure functionality and reliability. - Updated application structure to integrate provider management into the existing server architecture.
- Added a watcher to reset the provider configuration edit state when the provider configuration changes and is not empty.
…ations - Introduced new tables for character bookmarks and likes, including necessary foreign key constraints. - Updated the characters table to include new fields: avatar_url, character_avatar_url, cover_background_url, creator_role, price_credit, likes_count, bookmarks_count, interactions_count, and forks_count. - Adjusted character schema to reflect changes in data types for likes and bookmarks counts. - Enhanced character service methods to correctly handle integer values for likes and bookmarks. - Updated tests to validate the new functionality and ensure correct data handling.
…useAsyncState - Removed manual loading and error handling logic from character and provider catalog stores. - Integrated useAsyncState composable to manage asynchronous state and error handling. - Cleaned up fetch, create, update, and delete methods for better readability and maintainability. - Removed unused variables related to loading and error states from the stores.
- Renamed the "provider_configs" table to "user_settings_provider_configs" for clarity. - Dropped the old foreign key constraint and added a new one to ensure referential integrity with the "user" table. - Introduced a new snapshot file to reflect the updated database schema and configurations.
…ionships and tables - Added new 'character_covers' table to manage character cover images with necessary fields and relationships. - Moved 'characterLikes' and 'characterBookmarks' tables to a new 'user-character' schema for better organization. - Updated 'characters' and 'providers' schemas to reflect changes, including renaming and adding new relationships. - Improved data integrity by establishing foreign key constraints between new and existing tables.
… and user configuration management - Added new schemas for character covers and user provider configurations to improve data organization. - Updated character and provider services to support new CRUD operations for covers and user-specific configurations. - Refactored existing routes to accommodate changes in how providers and characters are retrieved and managed. - Enhanced tests to validate the new functionality and ensure correct handling of user-specific data.
Summary of ChangesHello @luoling8192, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the data models and associated services for characters and providers. It introduces a dedicated schema for character covers, moving cover-related fields out of the main character table. More importantly, it establishes a clear distinction between user-specific and system-wide provider configurations, allowing for more flexible and organized management of external service integrations. These changes improve data organization, enhance modularity, and lay the groundwork for more robust feature development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant and well-executed refactoring to the database schema and services. The introduction of new schemas for character covers and the separation of provider configurations into user-specific and system-wide tables greatly improve data organization and clarity. The corresponding updates to services, routes, and tests are thorough and validate the new functionality effectively. I have one piece of feedback regarding type safety that should be addressed.
| const provider = await providerService.createUserConfig({ | ||
| ...result.output, | ||
| ownerId: user.id, | ||
| }) | ||
| } as any) |
There was a problem hiding this comment.
The use of as any here bypasses TypeScript's type safety and should be avoided. It likely masks a type incompatibility between the object constructed from the request body and the NewUserProviderConfig type expected by the createUserConfig service method. Relying on as any can lead to runtime errors if the underlying types change in the future. Please resolve the type mismatch so that the type cast is no longer necessary.
| const provider = await providerService.createUserConfig({ | |
| ...result.output, | |
| ownerId: user.id, | |
| }) | |
| } as any) | |
| const provider = await providerService.createUserConfig({ | |
| ...result.output, | |
| ownerId: user.id, | |
| }) |
…bles - Added a new table for character covers to manage cover images with necessary fields. - Renamed existing tables for user character bookmarks and likes to improve clarity and organization. - Dropped outdated foreign key constraints and established new ones to ensure data integrity. - Updated the characters table by removing unused columns to streamline the schema. - Introduced a new snapshot file to reflect the latest database schema changes.
…apshot" This reverts commit bd37fbe.
luoling8192
changed the title
system_provider_configs and character_covers
1 participant
Uh oh!
There was an error while loading. Please reload this page.