Skip to content

fix(stage-ui): fix notify agent toolcall #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nekomeowww merged 7 commits into from
Jan 8, 2026
Merged

fix(stage-ui): fix notify agent toolcall #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95d8edf
always expect toolcalls available
shinohara-rin Jan 7, 2026
aba4db7
fix(stage-ui): `streamFrom` shouldn't resolve on `tool_calls`
shinohara-rin Jan 7, 2026
877e4bd
Merge branch 'main' into sr/fix-notify-agent-toolcall
shinohara-rin Jan 7, 2026
48d69cd
Update packages/stage-ui/src/stores/character-orchestrator.ts
shinohara-rin Jan 7, 2026
81ff360
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 7, 2026
3658779
default behaviour for `stream`
shinohara-rin Jan 7, 2026
b1263af
are you kidding me
shinohara-rin Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
[workspace]
members = [ "crates/tauri-plugin-ipc-audio-transcription-ort", "crates/tauri-plugin-ipc-audio-vad-ort", "crates/tauri-plugin-mcp", "crates/tauri-plugin-rdev", "crates/tauri-plugin-window-pass-through-on-hover", "crates/tauri-plugin-window-router-link" ]
members = [
Copy link
Copy Markdown
Member

@nekomeowww nekomeowww Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you again.

Copy link
Copy Markdown
Contributor Author

@shinohara-rin shinohara-rin Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autofix is certainly up to something :D

"crates/tauri-plugin-ipc-audio-transcription-ort",
"crates/tauri-plugin-ipc-audio-vad-ort",
"crates/tauri-plugin-mcp",
"crates/tauri-plugin-rdev",
"crates/tauri-plugin-window-pass-through-on-hover",
"crates/tauri-plugin-window-router-link"
]
resolver = "2"

[workspace.package]
Expand Down
2 changes: 2 additions & 0 deletions packages/stage-ui/src/stores/character-orchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ export const useCharacterOrchestratorStore = defineStore('character-orchestrator
sparkNoResponseTool,
sparkCommandTool,
],
supportsTools: true, // we expect tools to be supported
waitForTools: true, // see https://github.com/moeru-ai/airi/issues/907
onStreamEvent: async (streamEvent: StreamEvent) => {
if (streamEvent.type === 'text-delta') {
if (noResponse)
Expand Down
3 changes: 2 additions & 1 deletion packages/stage-ui/src/stores/llm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export interface StreamOptions {
onStreamEvent?: (event: StreamEvent) => void | Promise<void>
toolsCompatibility?: Map<string, boolean>
supportsTools?: boolean
waitForTools?: boolean // when true,won't resolve on finishReason=='tool_calls';
tools?: Tool[] | (() => Promise<Tool[] | undefined>)
}

Expand Down Expand Up @@ -72,7 +73,7 @@ async function streamFrom(model: string, chatProvider: ChatProvider, messages: M
async onEvent(event) {
try {
await options?.onStreamEvent?.(event as StreamEvent)
if (event.type === 'finish')
if (event.type === 'finish' && (event.finishReason !== 'tool_calls' || !options?.waitForTools))
resolve()
else if (event.type === 'error')
reject(event.error ?? new Error('Stream error'))
Expand Down
Loading