feat(stage-tamagotchi): add icon size settings for tamagotchi#940
Conversation
Summary of ChangesHello @leaft, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances user customization by adding a new setting for the sidebar controls island's icon size, allowing users to choose between automatic, large, or small icons. Concurrently, it addresses a critical UI bug by implementing a portal mechanism for combobox dropdowns, ensuring they render correctly without overlapping surrounding content. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully adds a new icon size setting for the controls island and fixes a UI overlapping issue with the combobox by correctly using ComboboxPortal. The code changes are well-implemented. I've provided a suggestion to correct a minor typo in a prop name.
| const props = withDefaults(defineProps<{ | ||
| needcontrolsIslandIconSizeSetting?: boolean | ||
| }>(), { | ||
| needcontrolsIslandIconSizeSetting: import.meta.env.RUNTIME_ENVIRONMENT === 'electron', | ||
| }) | ||
|
|
||
| const showControlsIsland = computed(() => props.needcontrolsIslandIconSizeSetting) |
There was a problem hiding this comment.
There's a small typo in the prop name needcontrolsIslandIconSizeSetting. It should be needsControlsIslandIconSizeSetting for better readability and grammatical correctness. I've updated it in the suggestion below, along with its usage in the showControlsIsland computed property.
const props = withDefaults(defineProps<{
needsControlsIslandIconSizeSetting?: boolean
}>(), {
needsControlsIslandIconSizeSetting: import.meta.env.RUNTIME_ENVIRONMENT === 'electron',
})
const showControlsIsland = computed(() => props.needsControlsIslandIconSizeSetting)
nekomeowww
changed the title
leaft
changed the title
…b.com/leaft/airi into add-icon-size-settings-for-tamagotchi
…ngs-for-tamagotchi
leaft
left a comment
leaft
left a comment
There was a problem hiding this comment.
I moved the logic to settings-store, but I’m concerned it’s becoming a bit bloated.
|
You are right, we can later split it down into different settings for each modules (appearance, language, general, etc.) |
nekomeowww
added
feat
2 participants
Description
添加侧边控制栏图标大小设置项-自动/默认/小图标。
修复
ComboboxContent导致的重叠问题，使用ComboboxPortal，问题如下图所示。Add sidebar controls island icon size settings: Auto(Responsive) / Large(Default) / Small.
Fix overlapping issues caused by
ComboboxContentby usingComboboxPortal(see the image below).Linked Issues
Additional Context