fix: add smooth control multiplier to VRM X axis slider#946
Conversation
Apply the same multiplier approach (*100 in getter, *0.01 in setter) to the X axis slider as the Y axis has, for smooth control on mobile. Closes moeru-ai#897
Summary of ChangesHello @lockrush-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for VRM model manipulation on mobile devices by introducing smooth control to the X-axis slider. By adopting a consistent scaling mechanism previously used for the Y-axis, it resolves responsiveness issues, making touch-based adjustments more precise and intuitive for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly applies a multiplier to the VRM X-axis slider to improve control smoothness, making it consistent with the existing Y-axis implementation. The change is straightforward and achieves its goal. I have one suggestion to improve code clarity and maintainability by making the relationship between the getter and setter scaling factors more explicit.
Description
This PR fixes the X axis slider for VRM models to have smooth control on mobile, matching the Y axis behavior.
Changes
* 100in getter,/ 100in setter) to VRM X axis sliderTechnical Details
The fix applies the same multiplier pattern used in the Y axis:
vrmPosition.value.x * 100(multiplies internal value for slider display)vrmPosition.value.x = value / 100(divides slider value back to internal scale)This provides finer granularity for touch-based input on mobile devices.
Testing Screenshot
Linked Issues
Closes #897