Skip to content

fix: add smooth control multiplier to VRM X axis slider#946

Merged
nekomeowww merged 2 commits intomoeru-ai:mainfrom
lockrush-dev:lockrush-dev/fix/vrm-x-axis-smooth-control
Jan 13, 2026
Merged

fix: add smooth control multiplier to VRM X axis slider#946
nekomeowww merged 2 commits intomoeru-ai:mainfrom
lockrush-dev:lockrush-dev/fix/vrm-x-axis-smooth-control

Conversation

@lockrush-dev
Copy link
Copy Markdown
Contributor

@lockrush-dev lockrush-dev commented Jan 13, 2026

Description

This PR fixes the X axis slider for VRM models to have smooth control on mobile, matching the Y axis behavior.

Changes

  • Applied multiplier approach (* 100 in getter, / 100 in setter) to VRM X axis slider
  • This matches the existing Y axis implementation for consistent smooth control
  • Fixes mobile touch control responsiveness for X axis positioning

Technical Details

The fix applies the same multiplier pattern used in the Y axis:

  • Getter: vrmPosition.value.x * 100 (multiplies internal value for slider display)
  • Setter: vrmPosition.value.x = value / 100 (divides slider value back to internal scale)

This provides finer granularity for touch-based input on mobile devices.

Testing Screenshot

image

Linked Issues

Closes #897

Apply the same multiplier approach (*100 in getter, *0.01 in setter)
to the X axis slider as the Y axis has, for smooth control on mobile.

Closes moeru-ai#897
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @lockrush-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience for VRM model manipulation on mobile devices by introducing smooth control to the X-axis slider. By adopting a consistent scaling mechanism previously used for the Y-axis, it resolves responsiveness issues, making touch-based adjustments more precise and intuitive for users.

Highlights

  • VRM X-axis Slider Fix: Implemented a fix for the VRM X-axis slider to provide smooth control on mobile devices, addressing responsiveness issues.
  • Consistent Control: Aligned the X-axis slider's behavior with the existing Y-axis implementation for consistent smooth control across both axes.
  • Multiplier Approach: Applied a multiplier approach, specifically multiplying by 100 in the getter and by 0.01 in the setter, to the VRM X-axis slider for finer granularity and improved touch input.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lockrush-dev lockrush-dev marked this pull request as ready for review January 13, 2026 02:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly applies a multiplier to the VRM X-axis slider to improve control smoothness, making it consistent with the existing Y-axis implementation. The change is straightforward and achieves its goal. I have one suggestion to improve code clarity and maintainability by making the relationship between the getter and setter scaling factors more explicit.

Comment thread packages/stage-layouts/src/components/Layouts/ViewControls/Inputs.vue Outdated
@nekomeowww nekomeowww merged commit 019ccaf into moeru-ai:main Jan 13, 2026
Joker-of-Gotham pushed a commit to Joker-of-Gotham/airi that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: on mobile, for VRM, X axis slider should have smooth control like Y axis

2 participants