feat(stage-ui,server): use optimistic request for provider catalog by luoling8192 · Pull Request #951 · moeru-ai/airi

luoling8192 · 2026-01-14T07:44:26Z

No description provided.

gemini-code-assist · 2026-01-14T07:44:47Z

Summary of Changes

Hello @luoling8192, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience in the stage-ui by implementing optimistic updates for provider catalog operations. Users will now experience immediate feedback when performing actions like adding, removing, or modifying provider configurations, as the UI state is updated instantly before server confirmation. This change improves perceived performance and responsiveness, with robust rollback mechanisms in place for handling server-side failures.

Highlights

New useOptimistic Composable: Introduced a new Vue composable, useOptimistic, designed to facilitate optimistic UI updates with automatic rollback capabilities on action failure, integrating with useAsyncState for loading and error tracking.
Optimistic Provider Catalog Operations: Implemented optimistic updates for addProvider, removeProvider, and commitProviderConfig functions within the provider-catalog store, providing immediate UI feedback for these actions.
Backend Schema Alignment: Modified the CreateProviderConfigSchema and CreateCharacterSchema to include an optional id field, allowing the client to provide IDs for new resources, which is crucial for optimistic creation flows.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-01-14T07:44:48Z

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

gemini-code-assist

Code Review

This pull request introduces a useOptimistic composable to provide a better user experience with optimistic UI updates, and refactors the provider catalog management to use it. This is a great improvement for perceived performance.

I've found a couple of high-severity issues:

In the new useOptimistic composable, there's a potential bug where the result of an asynchronous action can be lost if an onSuccess handler isn't provided.
In the provider-catalog store, when adding a new provider, if the server returns a different ID than the temporary one created on the client, the temporary entry is not cleaned up, leading to data inconsistencies.

I've provided detailed comments and code suggestions to address these points. Besides these, the changes are well-implemented and the new tests for useOptimistic are comprehensive.

packages/stage-ui/src/composables/use-optimistic.ts

packages/stage-ui/src/stores/provider-catalog.ts

packages/stage-ui/src/composables/use-optimistic.ts

packages/stage-ui/src/stores/provider-catalog.ts

nekomeowww · 2026-01-14T21:17:24Z

packages/stage-ui/src/composables/use-optimistic.ts

+ * A wrapper for performing optimistic updates with automatic rollback.
+ * Integrates with useAsyncState for loading/error tracking.
+ */
+export function useOptimistic<T, R = T>(options: UseOptimisticOptions<T, R>) {


Pehaps... useMutateOptimistic? Or useOptimisticMutate?

Could you explain why should we use mutate?

https://pinia-colada.esm.dev/guide/mutations.html

https://tanstack.com/query/latest/docs/framework/react/guides/mutations

https://swr.vercel.app/docs/mutation

Everyone calls this mutate

However, what inspired me is this React implementation, https://react.dev/reference/react/useOptimistic

Then should we divide this into two composables?

Co-authored-by: Neko <neko@ayaka.moe>

packages/stage-ui/src/composables/use-optimistic.ts

…oeru-ai#951) --------- Co-authored-by: Neko <neko@ayaka.moe>

feat(stage-ui, server): use optimistic request for provider catalog

363d1f8

gemini-code-assist bot reviewed Jan 14, 2026

View reviewed changes

packages/stage-ui/src/composables/use-optimistic.ts Outdated Show resolved Hide resolved

packages/stage-ui/src/stores/provider-catalog.ts Show resolved Hide resolved

chore: type

dce6b07

nekomeowww changed the title ~~feat(stage-ui, server): use optimistic request for provider catalog~~ feat(stage-ui,server): use optimistic request for provider catalog Jan 14, 2026

nekomeowww reviewed Jan 14, 2026

View reviewed changes

packages/stage-ui/src/composables/use-optimistic.ts Outdated Show resolved Hide resolved

nekomeowww reviewed Jan 14, 2026

View reviewed changes

packages/stage-ui/src/composables/use-optimistic.ts Outdated Show resolved Hide resolved

nekomeowww reviewed Jan 14, 2026

View reviewed changes

packages/stage-ui/src/stores/provider-catalog.ts Outdated Show resolved Hide resolved

nekomeowww reviewed Jan 14, 2026

View reviewed changes

luoling8192 and others added 2 commits January 15, 2026 15:35

Update packages/stage-ui/src/composables/use-optimistic.ts

219a716

Co-authored-by: Neko <neko@ayaka.moe>

feat: lazy

328344f

nekomeowww reviewed Jan 15, 2026

View reviewed changes

packages/stage-ui/src/composables/use-optimistic.ts Outdated Show resolved Hide resolved

nekomeowww and others added 4 commits January 15, 2026 16:42

Update packages/stage-ui/src/composables/use-optimistic.ts

9fca185

Merge branch 'main' into dev/use-optimistic

5f131de

Merge branch 'main' into dev/use-optimistic

c2bc128

chore: rename

e8d78ce

nekomeowww approved these changes Jan 16, 2026

View reviewed changes

nekomeowww merged commit 4292535 into main Jan 16, 2026
9 checks passed

nekomeowww deleted the dev/use-optimistic branch January 16, 2026 16:17

Joker-of-Gotham pushed a commit to Joker-of-Gotham/airi that referenced this pull request Jan 29, 2026

feat(stage-ui,server): use optimistic request for provider catalog (m…

772de61

…oeru-ai#951) --------- Co-authored-by: Neko <neko@ayaka.moe>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(stage-ui,server): use optimistic request for provider catalog#951

feat(stage-ui,server): use optimistic request for provider catalog#951
nekomeowww merged 8 commits intomainfrom
dev/use-optimistic

luoling8192 commented Jan 14, 2026

Uh oh!

gemini-code-assist bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nekomeowww Jan 14, 2026

Uh oh!

luoling8192 Jan 15, 2026

Uh oh!

nekomeowww Jan 15, 2026

Uh oh!

luoling8192 Jan 15, 2026

Uh oh!

nekomeowww Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

luoling8192 commented Jan 14, 2026

Uh oh!

gemini-code-assist bot commented Jan 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nekomeowww Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

luoling8192 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

nekomeowww Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

luoling8192 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

nekomeowww Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 14, 2026 •

edited

Loading