fix(stage-ui): update connection icon to use correct variant

[leaft]

Description

Fix connection icon error. Maybe route-bold-duotone ? @LemonNekoGH

Linked Issues

#960

Additional Context

[gemini-code-assist]

Summary of Changes

Hello @leaft, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor user interface bug where an incorrect icon was being displayed for the connection settings. By updating the icon variant, the UI will now present the intended visual representation for connection-related options, improving consistency and user experience.

Highlights

• Icon Correction: The connection icon in the settings UI has been updated from i-solar:router-bold-duotone to i-solar:route-bold-duotone to display the correct variant.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

[gemini-code-assist]

Code Review

This pull request correctly fixes a typo in an icon name. However, the change had to be applied to two separate files (apps/stage-tamagotchi/src/renderer/pages/settings/index.vue and packages/stage-pages/src/pages/settings/index.vue) because the list of settings is duplicated. This indicates a maintainability issue. I've added comments suggesting a refactor to centralize this configuration in a shared utility. This will make future updates easier and less error-prone.

[gemini-code-assist]

This change is correct, but its necessity in two files highlights a code duplication issue. The settings array is nearly identical to the one in packages/stage-pages/src/pages/settings/index.vue.

To improve maintainability, I recommend refactoring this by extracting the common settings into a shared function.

For example, you could create a shared utility:

// In a shared file, e.g., within a 'utils' or 'config' directory
export const getBaseSettings = (t) => [
  // ... all common settings objects, including this 'connection' one
];

Then, this component, which uses the base list without modifications, can be simplified to:

import { getBaseSettings } from '...'; // path to shared utility

const settings = computed(() => getBaseSettings(t));

This would centralize the settings configuration, making future changes much easier and less error-prone.

[gemini-code-assist]

This change is correct, but its necessity in two files highlights a code duplication issue. The settings array is nearly identical to the one in apps/stage-tamagotchi/src/renderer/pages/settings/index.vue.

To improve maintainability, I recommend refactoring this. You could extract the common settings into a shared function (as suggested in the other file's comment).

This component, which has an additional 'data' setting, could then be implemented like this:

import { getBaseSettings } from '...'; // path to shared utility

const settings = computed(() => {
    const base = getBaseSettings(t);
    const providersIndex = base.findIndex(s => s.to === '/settings/providers');
    
    // Insert the 'data' setting at the correct position
    if (providersIndex !== -1) {
        base.splice(providersIndex + 1, 0, {
            title: t('settings.pages.data.title'),
            description: t('settings.pages.data.description'),
            icon: 'i-solar:database-bold-duotone',
            to: '/settings/data',
        });
    }
    
    return base;
});

This approach centralizes the common configuration while allowing for specific adjustments, significantly improving maintainability.

[ricardomiss]

I think is i-solar:wi-fi-router-bold-duotone, i dont remember them using i-solar:route-bold-duotone