fix(split-layout): Pass setCurrentSplitLayout to ResetPassword to prevent navigation split layout blips#20361
Conversation
…vent navigation split layout blips Because: * Navigating from a page with split layout to a page without, like from signin to reset password, keeps the transition screens with loading spinner set to 'split layout', causing visual blips of split layout while going through the reset PW flow This commit: * Passes setCurrentSplitLayout on the reset PW page to reset split layout back to a non-split layout closes FXA-13245
vpomerleau
approved these changes
Apr 13, 2026
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Tested locally and this looks good to me! No blip.
We may also want to pass this prop to other pages like InlineTotpSetup, InlineRecoveryKeySetup, SetPassword?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-13245
To test this, run Strapi locally and set "split layout" to true for at least the signin page. Then go through the reset PW flow and compare it to the video in the ticket - there's no longer "blips" of split layout through the flow.