Skip to content

Check preorder assertion is true in Preorder()#266

Open
ms609 wants to merge 3 commits intomainfrom
defensive-preorder
Open

Check preorder assertion is true in Preorder()#266
ms609 wants to merge 3 commits intomainfrom
defensive-preorder

Conversation

@ms609
Copy link
Copy Markdown
Owner

@ms609 ms609 commented Mar 29, 2026

No description provided.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

Performance benchmark results

Call Status Change Time (ms)
as.Splits(bigTrees) ⚪ NSD -3.94% 21.8 →
23, 20.8
as.Splits(someTrees) ⚪ NSD -1.49% 11.1 →
11.4, 11.3
Consensus(forest1k.888, check = FALSE) 🟠 Slower 🙁 -18.78% 99.7 →
119, 118
Consensus(forest201.80, check = FALSE) 🟠 Slower 🙁 -31.52% 3.98 →
5.26, 5.21
Consensus(forest21.260, 0.5, FALSE) ⚪ NSD -15.22% 1.23 →
1.41, 1.41
Consensus(forest21.260) ⚪ NSD -15.42% 1.24 →
1.43, 1.43
Consensus(forestMaj, 0.5, FALSE) 🟠 Slower 🙁 -24.06% 2.95 →
3.68, 3.64
DropTip(tr2000, 5) ⚪ NSD 1.35% 16.9 →
16.6, 16.7
DropTip(tr80, 5) ⚪ NSD 0.54% 0.106 →
0.105, 0.105
DropTip(unlen2k, 5) ⚪ NSD -24.83% 0.214 →
0.283, 0.211
DropTip(unlen80, 5) ⚪ NSD -2.68% 0.04 →
0.0414, 0.0408
lapply(bigSplits, as.phylo) ⚪ NSD 0.07% 29.3 →
29.4, 29
lapply(someSplits, as.phylo) ⚪ NSD -1.94% 13.7 →
14.1, 13.8
PathLengths(tr2000, full = TRUE) ⚪ NSD -0.87% 15.9 →
16.3, 15.8
PathLengths(tr80, full = TRUE) ⚪ NSD 0.26% 0.1 →
0.102, 0.0984
PathLengths(tr80Unif, full = TRUE) ⚪ NSD -0.22% 0.102 →
0.105, 0.101
RootTree(tr2000, 5) ⚪ NSD 3.52% 0.395 →
0.377, 0.383
RootTree(tr80, c("t3", "t36")) ⚪ NSD 1.2% 0.0709 →
0.0696, 0.0704
RootTree(tr80, "t3") ⚪ NSD 1.16% 0.0501 →
0.0496, 0.0495
RootTree(tr80, "t30") ⚪ NSD 1% 0.0499 →
0.0495, 0.0494
RootTree(unlen2k, 5) ⚪ NSD -0.33% 0.33 →
0.333, 0.325
RootTree(unlen80, c("t3", "t36")) ⚪ NSD 0.92% 0.0651 →
0.0646, 0.0644
RootTree(unlen80, "t3") ⚪ NSD -0.54% 0.0424 →
0.0429, 0.0424
RootTree(unlen80, "t30") ⚪ NSD -0.47% 0.043 →
0.0435, 0.0429
TreeDist::RobinsonFoulds(forest201.80) ⚪ NSD -2.74% 15.8 →
16.4, 16
TreeDist::RobinsonFoulds(forest21.888) ⚪ NSD 0.78% 3.31 →
3.29, 3.28
TreeTools:::path_lengths(tr80$edge, tr80$edge.length, FALSE) ⚪ NSD 0.86% 0.0906 →
0.0911, 0.0883
TreeTools:::postorder_order(bal40) ⚪ NSD 0.6% 0.00166 →
0.00165, 0.00165
TreeTools:::postorder_order(bal40k) ⚪ NSD 0.71% 0.543 →
0.536, 0.544
TreeTools:::postorder_order(dbal40) ⚪ NSD 5.95% 0.00183 →
0.00173, 0.00171
TreeTools:::postorder_order(dbal40k) ⚪ NSD 4.43% 2.14 →
2.04, 2.1
TreeTools:::postorder_order(dpec40) ⚪ NSD -0.79% 0.00254 →
0.00253, 0.00257
TreeTools:::postorder_order(dpec40k) ⚪ NSD -0.11% 3290 →
3300, 3300
TreeTools:::postorder_order(drnd80) ⚪ NSD 0% 0.00406 →
0.00405, 0.00406
TreeTools:::postorder_order(nbal40) ⚪ NSD -1.54% 0.00201 →
0.00205, 0.00204
TreeTools:::postorder_order(nbal40k) ⚪ NSD -0.62% 2.17 →
2.19, 2.18
TreeTools:::postorder_order(npec40) ⚪ NSD -0.72% 0.00281 →
0.00281, 0.00285
TreeTools:::postorder_order(npec40k) 🟣 ~same -0.35% 3320 →
3330, 3320
TreeTools:::postorder_order(nrnd80) ⚪ NSD -0.87% 0.00458 →
0.00461, 0.00463
TreeTools:::postorder_order(pec40) ⚪ NSD -0.68% 0.00163 →
0.00163, 0.00165
TreeTools:::postorder_order(pec40k) ⚪ NSD 2.82% 0.448 →
0.534, 0.429
TreeTools:::postorder_order(rnd80) ⚪ NSD -0.48% 0.00209 →
0.00208, 0.00212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant