Fix MessageUnpacker#unpackString in case that string length is more than...#215
Merged
xerial merged 1 commit intov07-developfrom Apr 4, 2015
Merged
Fix MessageUnpacker#unpackString in case that string length is more than...#215xerial merged 1 commit intov07-developfrom
xerial merged 1 commit intov07-developfrom
Conversation
Member
|
I found another bug; This part should use |
Member
There was a problem hiding this comment.
I think there is no guarantee that the read length from the input always matches Math.min(buffer.size() - position, strLen-cursor) when OVERFLOW (output buffer has insufficient space) happens. When OVERFLOW occurs, the input data might be partially read. That is why I compute readLen as bb.limit() - bb.remaining().
Member
There was a problem hiding this comment.
Ah. I was wrong. readLen can be retrieved by bb.position() since we created a new ByteBuffer at
ByteBuffer bb = buffer.toByteBuffer(position, readLen);
whose initial position is 0.
Member
|
Now I got it. I don't need to set |
xerial
added a commit
that referenced
this pull request
Apr 4, 2015
Fix MessageUnpacker#unpackString in case that string length is more than...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified MessageUnpacker#unpackString to fix #209.
@xerial Can you review this change?