asShort in ImmutableLongValueImpl should check isInShortRange#287
Merged
komamitsu merged 3 commits intomsgpack:v07-developfrom Nov 11, 2015
Merged
asShort in ImmutableLongValueImpl should check isInShortRange#287komamitsu merged 3 commits intomsgpack:v07-developfrom
komamitsu merged 3 commits intomsgpack:v07-developfrom
Conversation
Contributor
Author
|
Is it possible to do a hotfix/patch release for this? |
Member
|
@mecp Could you add a test for it? |
Contributor
Author
|
@komamitsu I have added tests for range checks and casts. Please don't judge the code, as these are first ever scala lines produced by me. please share If something is inappropriate. |
komamitsu
added a commit
that referenced
this pull request
Nov 11, 2015
asShort in ImmutableLongValueImpl should check isInShortRange
Member
|
Great. Thanks! |
Member
|
@mecp Released 0.7.1 that includes this change. |
Contributor
Author
|
@komamitsu Arigato. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asShort() in ImmutableLongvalueImpl should check isInShortRange() instead of isInByteRange()