resetDecoder should be called once per decoding#387
Merged
xerial merged 1 commit intomsgpack:developfrom Sep 23, 2016
Merged
Conversation
xerial
reviewed
Sep 23, 2016
| this.sequence = checkNotNull(sequence, "input sequence is null"); | ||
| try { | ||
| nextInput(); | ||
| } catch (IOException ignore) { |
Member
There was a problem hiding this comment.
code style check error: https://travis-ci.org/msgpack/msgpack-java/jobs/162190720#L507
miniway
force-pushed
the
fix_truncate
branch
from
f634f34 to
9467f61
Compare
xerial
reviewed
Sep 23, 2016
| } | ||
|
|
||
| "read numeric data at buffer boundary" taggedAs("boundary2") in { | ||
| "read data at buffer boundary" taggedAs("boundary2") in { |
Member
There was a problem hiding this comment.
This test case is intended for checking a bug on unpackInteger that found in the past. We should have another test case for string.
Member
|
Merged in #388 |
frsyuki
reviewed
Sep 23, 2016
| private Enumeration<? extends MessageBufferInput> sequence; | ||
| private MessageBufferInput input; | ||
|
|
||
| public SequenceMessageBufferInput(Enumeration<? extends MessageBufferInput> sequence) |
Member
There was a problem hiding this comment.
can we use Iterator, Stream, Iterable, or Collection instead of Enumeration? or how about moving this to test package only for now? Because Enumeration is considered as a deprecated interface used only by old classes such as Vector or Hashtable.
Member
There was a problem hiding this comment.
Agreed. Iterator<MessageBufferInput> would work. And this should be in test package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple MessageBuffer involved at
unpackStringfirst bytes can be removed becauseresetDecoderis called multiple times.