Skip to content

Avoid using CharsetEncoder of Android 4.x#409

Merged
komamitsu merged 1 commit intodevelopfrom
android4-pack-string
Jan 23, 2017
Merged

Avoid using CharsetEncoder of Android 4.x#409
komamitsu merged 1 commit intodevelopfrom
android4-pack-string

Conversation

@komamitsu
Copy link
Member

Android 4.x has a bug in CharsetEncoder where offset calculation is
wrong.
See
- #405
- #406
@komamitsu
Copy link
Member Author

@frsyuki Can you review this change?

@frsyuki
Copy link
Member

frsyuki commented Jan 23, 2017

LGTM 👍
Nice improvement. Please merge

@komamitsu
Copy link
Member Author

Thanks!

@dbrgn
Copy link

dbrgn commented Feb 16, 2017

Is a release containing this fix planned soon? :)

@komamitsu
Copy link
Member Author

@dbrgn Released 0.8.12 that contains this fix.

@dbrgn
Copy link

dbrgn commented Feb 19, 2017

@komamitsu Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants