Skip to content

Support numeric types in MessagePackParser.getText() #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 2 commits into from
Aug 30, 2020
Merged

Support numeric types in MessagePackParser.getText() #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
793cfcd
Support numeric types in MessagePackParser.getText()
komamitsu Aug 26, 2020
bd0ebe1
Update sbt to avoid download failures
komamitsu Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,14 @@ public String getText()
return stringValue;
case BYTES:
return new String(bytesValue, MessagePack.UTF8);
case INT:
return String.valueOf(intValue);
case LONG:
return String.valueOf(longValue);
case DOUBLE:
return String.valueOf(doubleValue);
case BIG_INT:
return String.valueOf(biValue);
default:
throw new IllegalStateException("Invalid type=" + type);
}
Expand Down
16 changes: 16 additions & 0 deletions msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,9 @@ public void testReadPrimitives()
MessagePacker packer = MessagePack.newDefaultPacker(out);
packer.packString("foo");
packer.packDouble(3.14);
packer.packInt(Integer.MIN_VALUE);
packer.packLong(Long.MAX_VALUE);
packer.packBigInteger(BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE));
byte[] bytes = {0x00, 0x11, 0x22};
packer.packBinaryHeader(bytes.length);
packer.writePayload(bytes);
Expand All @@ -374,10 +376,24 @@ public void testReadPrimitives()
JsonParser parser = factory.createParser(new FileInputStream(tempFile));
assertEquals(JsonToken.VALUE_STRING, parser.nextToken());
assertEquals("foo", parser.getText());

assertEquals(JsonToken.VALUE_NUMBER_FLOAT, parser.nextToken());
assertEquals(3.14, parser.getDoubleValue(), 0.0001);
assertEquals("3.14", parser.getText());

assertEquals(JsonToken.VALUE_NUMBER_INT, parser.nextToken());
assertEquals(Integer.MIN_VALUE, parser.getIntValue());
assertEquals(Integer.MIN_VALUE, parser.getLongValue());
assertEquals("-2147483648", parser.getText());

assertEquals(JsonToken.VALUE_NUMBER_INT, parser.nextToken());
assertEquals(Long.MAX_VALUE, parser.getLongValue());
assertEquals("9223372036854775807", parser.getText());

assertEquals(JsonToken.VALUE_NUMBER_INT, parser.nextToken());
assertEquals(BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE), parser.getBigIntegerValue());
assertEquals("9223372036854775808", parser.getText());

assertEquals(JsonToken.VALUE_EMBEDDED_OBJECT, parser.nextToken());
assertEquals(bytes.length, parser.getBinaryValue().length);
assertEquals(bytes[0], parser.getBinaryValue()[0]);
Expand Down
Loading