Skip to content

Fix a bug that fails to serialize BigDecimal #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 1 commit into from
Dec 17, 2020
Merged

Fix a bug that fails to serialize BigDecimal #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ private void packBigDecimal(BigDecimal decimal)
if (failedToPackAsBI) {
double doubleValue = decimal.doubleValue();
//Check to make sure this BigDecimal can be represented as a double
if (!decimal.stripTrailingZeros().toEngineeringString().equals(BigDecimal.valueOf(doubleValue).toEngineeringString())) {
if (!decimal.stripTrailingZeros().toEngineeringString().equals(
BigDecimal.valueOf(doubleValue).stripTrailingZeros().toEngineeringString())) {
throw new IllegalArgumentException("MessagePack cannot serialize a BigDecimal that can't be represented as double. " + decimal);
}
messagePacker.packDouble(doubleValue);
Expand Down
3 changes: 3 additions & 0 deletions msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,12 @@ public void testBigDecimal()
double d0 = 1.23456789;
double d1 = 1.23450000000000000000006789;
String d2 = "12.30";
String d3 = "0.00001";
List<BigDecimal> bigDecimals = Arrays.asList(
BigDecimal.valueOf(d0),
BigDecimal.valueOf(d1),
new BigDecimal(d2),
new BigDecimal(d3),
BigDecimal.valueOf(Double.MIN_VALUE),
BigDecimal.valueOf(Double.MAX_VALUE),
BigDecimal.valueOf(Double.MIN_NORMAL)
Expand All @@ -320,6 +322,7 @@ public void testBigDecimal()
assertEquals(d0, unpacker.unpackDouble(), 0.000000000000001);
assertEquals(d1, unpacker.unpackDouble(), 0.000000000000001);
assertEquals(Double.valueOf(d2), unpacker.unpackDouble(), 0.000000000000001);
assertEquals(Double.valueOf(d3), unpacker.unpackDouble(), 0.000000000000001);
assertEquals(Double.MIN_VALUE, unpacker.unpackDouble(), 0.000000000000001);
assertEquals(Double.MAX_VALUE, unpacker.unpackDouble(), 0.000000000000001);
assertEquals(Double.MIN_NORMAL, unpacker.unpackDouble(), 0.000000000000001);
Expand Down