Prevent having two different unpacking methods#548
Merged
xerial merged 2 commits intomsgpack:developfrom May 11, 2021
cyberdelia:no-map-land
Merged
Prevent having two different unpacking methods#548xerial merged 2 commits intomsgpack:developfrom cyberdelia:no-map-land
xerial merged 2 commits intomsgpack:developfrom
cyberdelia:no-map-land
Conversation
xerial
reviewed
May 11, 2021
xerial
reviewed
May 11, 2021
Contributor
Author
|
Well, I'm still worried by the lack of tests failing because of my improper logic copy/pasta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent having two different unpacking methods in the unpacker:
unpackValueexclusively use arrays for both arrays and maps , andunpackValue(Variable)uses list and map. This will prevent having two different behaviour when unpacking values and prevent some code duplication.