Implemented feature to add new attributes to existing Openshift allocations#202
Conversation
naved001
left a comment
There was a problem hiding this comment.
looks like a good feature to have. Just a question inline
2cdabf5 to
1f7348f
Compare
1f7348f to
b82b6e9
Compare
|
@naved001 @knikolla This has been rebased and updated, and now has priority because the IBM Storage PR will now be built on it. |
…ations `validate_allocations` will now check if an Openshift allocation does not have a quota value set on either the Coldfront or Openshift side. In this case, it will set the default quota value for the allocation. Due to the complexity of Openstack quotas, this feature is only implemented for Openshift allocations for now.
b82b6e9 to
11587a3
Compare
knikolla
left a comment
There was a problem hiding this comment.
Looks good to me.
Some comments that don't need to be fixed now:
- I don't love that the behavior of
validate_allocationsbetween OpenStack and OpenShift is now different. We should try to factor out the commonalities and implement features like this in an agnostic way. - Could the
elsehave been replaced with anelifto keep the depth of the conditional statements flatter?
@knikolla Hilariously enough, @naved001 has already asked a similar question before. I'll try to refactor this code block within this year. I could use |
Ah, makes complete sense. I had a similar moment of understanding before I left on vacation, which I clearly forgot when coming back. |
Closes #200. Built on top of #201. This PR consists of the last commit.
validate_allocationswill now check if an Openshift allocation does not have a quota value set on either the Coldfront or Openshift side. In this case, it will set the default quota value for the allocation.Due to the complexity of Openstack quotas, this feature is only
implemented for Openshift allocations for now.